Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the slow path(NCHW) for avg_pool3d #34994

Closed
wants to merge 1 commit into from

Conversation

lly-zero-one
Copy link
Contributor

Summary: Use the fast path for NCHW input tensor

Test Plan: run the pool unit tests

Differential Revision: D20522082

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20522082

Copy link
Contributor

@dskhudia dskhudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please make sure the tests pass.

@dr-ci
Copy link

dr-ci bot commented Mar 19, 2020

💊 CircleCI build failures summary and remediations

As of commit 1fbdcd8 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 5/5 broken upstream at merge base c8f665d since Mar 19

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 5 upstream failures:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 9 times.

Summary:
Pull Request resolved: pytorch#34994

Use the fast path for NCHW input tensor

Test Plan: run the pool unit tests

Differential Revision: D20522082

fbshipit-source-id: 56fdb6dc095f40c9c410b74576dd7a214bc6ad56
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20522082

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20522082

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fd57e09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants