Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load all DLLs in the lib directory for Windows (v1.5.0) #35368

Merged

Conversation

@peterjc123
Copy link
Contributor

peterjc123 commented Mar 25, 2020

#35362 for release v1.5.

@dr-ci

This comment has been minimized.

Copy link

dr-ci bot commented Mar 25, 2020

💊 CircleCI build failures summary and remediations

As of commit d4d7160 (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵 2 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages (reran 2 jobs to discount flakiness):

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 07:39:43 AssertionError: 11 not less than or equal to 1e-05 :
Mar 25 07:39:43 ---------------------------------------------------------------------- 
Mar 25 07:39:43 Traceback (most recent call last): 
Mar 25 07:39:43   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 07:39:43     self._join_processes(fn) 
Mar 25 07:39:43   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 07:39:43     self._check_return_codes(elapsed_time) 
Mar 25 07:39:43   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 25 07:39:43     self.assertEqual(first_process.exitcode, 0) 
Mar 25 07:39:43   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 07:39:43     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 07:39:43 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 25 07:39:43  
Mar 25 07:39:43 ---------------------------------------------------------------------- 
Mar 25 07:39:43 Ran 27 tests in 30.957s 
Mar 25 07:39:43  
Mar 25 07:39:43 FAILED (failures=1) 
Mar 25 07:39:43  
Mar 25 07:39:43 Generating XML reports... 
Mar 25 07:39:44 Traceback (most recent call last): 
Mar 25 07:39:44   File "test/run_test.py", line 674, in <module> 
Mar 25 07:39:44     main() 

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (2/2)

Step: "Test" (full log | pattern match details) <confirmed not flaky by 2 failures>

Mar 25 08:17:55 AssertionError: 11 not less than or equal to 1e-05 :
Mar 25 08:17:55 ---------------------------------------------------------------------- 
Mar 25 08:17:55 Traceback (most recent call last): 
Mar 25 08:17:55   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 25 08:17:55     self._join_processes(fn) 
Mar 25 08:17:55   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 25 08:17:55     self._check_return_codes(elapsed_time) 
Mar 25 08:17:55   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 328, in _check_return_codes 
Mar 25 08:17:55     self.assertEqual(first_process.exitcode, 0) 
Mar 25 08:17:55   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 25 08:17:55     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 25 08:17:55 AssertionError: 11 not less than or equal to 1e-05 :  
Mar 25 08:17:55  
Mar 25 08:17:55 ---------------------------------------------------------------------- 
Mar 25 08:17:55 Ran 27 tests in 21.448s 
Mar 25 08:17:55  
Mar 25 08:17:55 FAILED (failures=1) 
Mar 25 08:17:55  
Mar 25 08:17:55 Generating XML reports... 
Mar 25 08:17:55 Traceback (most recent call last): 
Mar 25 08:17:55   File "test/run_test.py", line 674, in <module> 
Mar 25 08:17:55     main() 

1 job timed out:

  • pytorch_macos_10_13_py3_test

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 4 times.

@gchanan gchanan merged commit 651fa88 into pytorch:release/1.5 Mar 25, 2020
41 of 45 checks passed
41 of 45 checks passed
quick-checks
Details
flake8-py3
Details
flake8-py2
Details
clang-tidy clang-tidy
Details
ci/circleci: pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test Your tests failed on CircleCI
Details
ci/circleci: pytorch_linux_xenial_py3_6_gcc5_4_test Your tests failed on CircleCI
Details
ci/circleci: pytorch_macos_10_13_py3_test Your tests failed on CircleCI
Details
pr/py3.6-clang7-rocmdeb-ubuntu16.04 Build failed
Details
ci/circleci: binary_linux_conda_2_7_cpu_devtoolset7_build Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_conda_2_7_cpu_devtoolset7_test Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_libtorch_2_7m_cpu_devtoolset7_shared-with-deps_build Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_libtorch_2_7m_cpu_devtoolset7_shared-with-deps_test Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_libtorch_2_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_build Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_libtorch_2_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_test Your tests passed on CircleCI!
Details
ci/circleci: binary_linux_manywheel_2_7mu_cpu_devtoolset7_build Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_main_py3_6_clang7_ubuntu16_04_build Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_main_py3_6_clang7_ubuntu16_04_test Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_ort1_py3_6_clang7_ubuntu16_04_test Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_ort2_py3_6_clang7_ubuntu16_04_test Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_py2_gcc5_ubuntu16_04_build Your tests passed on CircleCI!
Details
ci/circleci: caffe2_onnx_py2_gcc5_ubuntu16_04_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_cpp_doc_push Your tests passed on CircleCI!
Details
ci/circleci: pytorch_ios_11_2_1_x86_64_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_libtorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_libtorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_backward_compatibility_check_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_6_gcc5_4_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_6_gcc5_4_ge_config_legacy_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_android_ndk_r19c_x86_32_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_asan_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_asan_test Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_mobile_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_mobile_custom_build_dynamic Your tests passed on CircleCI!
Details
ci/circleci: pytorch_linux_xenial_py3_clang5_mobile_custom_build_static Your tests passed on CircleCI!
Details
ci/circleci: pytorch_macos_10_13_py3_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_python_doc_push Your tests passed on CircleCI!
Details
ci/circleci: pytorch_windows_vs2019_py36_cuda10.1_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_windows_vs2019_py36_cuda10.1_test1 Your tests passed on CircleCI!
Details
ci/circleci: pytorch_windows_vs2019_py36_cuda10.1_test2 Your tests passed on CircleCI!
Details
ci/circleci: pytorch_xla_linux_xenial_py3_6_clang7_build Your tests passed on CircleCI!
Details
ci/circleci: pytorch_xla_linux_xenial_py3_6_clang7_test Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
pr/caffe2-py3.6-devtoolset7-rocmrpm-centos7-test Build successful
Details
@peterjc123 peterjc123 deleted the peterjc123:load_all_dlls_in_lib_directory_v1.5.0 branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.