Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes default dtype value for onnx hardtanh export (opset11) #35467

Closed

Conversation

@julianmack
Copy link
Contributor

julianmack commented Mar 26, 2020

Oneline fix to @lara-hdr 's PR #30169.

Default dtype value should be set when dtype is None rather than when dtype is not None.

I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works).

@dr-ci
Copy link

dr-ci bot commented Mar 26, 2020

💊 CircleCI build failures summary and remediations

As of commit 4d5bd61 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 1 time.

Copy link
Contributor

mruberry left a comment

Thanks!

@mruberry mruberry added the triaged label Mar 27, 2020
Copy link
Contributor

facebook-github-bot left a comment

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2020

@mruberry merged this pull request in ad1091f.

gchanan added a commit to gchanan/pytorch that referenced this pull request Apr 7, 2020
…#35467)

Summary:
Oneline fix to lara-hdr 's PR pytorch#30169.

Default `dtype` value should be set when `dtype is None` rather than when `dtype is not None`.

I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works).
Pull Request resolved: pytorch#35467

Differential Revision: D20686048

Pulled By: mruberry

fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31
@julianmack
Copy link
Contributor Author

julianmack commented Jul 7, 2020

This hasn't made it into 1.5.0 or 1.5.1. Will this be going into a release soon @mruberry?

@mruberry
Copy link
Contributor

mruberry commented Jul 7, 2020

This will appear in the 1.6 release, which I think will be available in the next month or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.