Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX]Update Dropout Export #37641

Closed
wants to merge 19 commits into from
Closed

[ONNX]Update Dropout Export #37641

wants to merge 19 commits into from

Conversation

@KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented May 1, 2020

Dropout operator in ONNX has additional input: training_mode.
Update Dropout export to match changes made in ONNX

@dr-ci
Copy link

@dr-ci dr-ci bot commented May 1, 2020

💊 CI failures summary and remediations

As of commit 733d8b4 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 23 times.

Loading

@KsenijaS KsenijaS changed the title Update Dropout Export [ONNX]Update Dropout Export May 1, 2020
@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 1, 2020

Loading

Copy link
Collaborator

@BowenBao BowenBao left a comment

LGTM

edit: failing onnx checker test in CI, looks like also need to update onnx version in CI.

Loading

Copy link
Contributor

@lara-hdr lara-hdr left a comment

@houseroad the CI is failing because ONNX submodule needs the be updated.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 5, 2020

@houseroad is there an ETA for the update of the ONNX submodule?

Loading

test/onnx/test_utility_funs.py Outdated Show resolved Hide resolved
Loading
@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 14, 2020

@houseroad I don't think build failure is related to the PR. LGTM

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

Copy link
Member

@houseroad houseroad left a comment

thanks

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented May 19, 2020

@houseroad merged this pull request in 5b12c29.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants