Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests in test_pytorch_onnx_onnxruntime #37868

Closed
wants to merge 4 commits into from

Conversation

@KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented May 5, 2020

Enable tests in tests/onnx/test_pytorch_onnx_onnxruntime.py for:

  • Einsum
  • SoftmaxCrossEntropy
  • NLLLoss
  • normalize
  • pixel_shuffle
  • test_interpolate_no_shape
  • test_arange_dynamic
  • test_slice_neg_large_negone
    since there is a support in ORT for these operators.
@KsenijaS KsenijaS changed the title Enable tests for Einsum, SoftmaxCrossEntropy, NLLLoss Enable tests for Einsum, SoftmaxCrossEntropy and NLLLoss May 5, 2020
@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 5, 2020

@neginraoof @lara-hdr please review

Loading

@dr-ci
Copy link

@dr-ci dr-ci bot commented May 5, 2020

💊 CI failures summary and remediations

As of commit 2d3276f (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 5 times.

Loading

Copy link
Member

@houseroad houseroad left a comment

The tests failed

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 6, 2020

The tests failed

PR #37239 updates ort nightly version, after it's merged I will rebase my branch and the tests should pass.

Loading

@neginraoof
Copy link
Collaborator

@neginraoof neginraoof commented May 8, 2020

@KsenijaS ORT is now updated in master. Please rebase this.
Thanks.

Loading

Copy link
Contributor

@lara-hdr lara-hdr left a comment

LGTM. thanks!

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 12, 2020

@houseroad CI is green! LGTM.

Loading

@KsenijaS KsenijaS changed the title Enable tests for Einsum, SoftmaxCrossEntropy and NLLLoss Enable tests in test_pytorch_onnx_onnxruntime May 15, 2020
Copy link
Member

@houseroad houseroad left a comment

Looks good. Thanks!

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented May 18, 2020

@houseroad merged this pull request in 711f258.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants