Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX Export Support for Celu #38243

Closed
wants to merge 10 commits into from
Closed

ONNX Export Support for Celu #38243

wants to merge 10 commits into from

Conversation

@KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented May 11, 2020

Add ONNX export support for torch.nn.CELU

@dr-ci
Copy link

@dr-ci dr-ci bot commented May 11, 2020

💊 CI failures summary and remediations

As of commit 4ade58e (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 23 times.

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

torch/onnx/symbolic_opset12.py Show resolved Hide resolved
Loading
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

test/onnx/test_utility_funs.py Outdated Show resolved Hide resolved
Loading
Copy link
Collaborator

@neginraoof neginraoof left a comment

LGTM. Thanks.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 20, 2020

@houseroad please review

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 26, 2020

@houseroad for review. Thanks!

Loading

@ezyang ezyang removed the request for review from houseroad May 26, 2020
@ezyang ezyang removed the triaged label May 26, 2020
ezyang
ezyang approved these changes May 26, 2020
Copy link
Contributor

@ezyang ezyang left a comment

@KsenijaS please go ahead and land this

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 26, 2020

@ezyang I don't think I have privileges to land a PR.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 27, 2020

@ezyang can you please merge this PR. Thanks!

Loading

@ezyang
Copy link
Contributor

@ezyang ezyang commented May 27, 2020

Oh, @houseroad imported it, I'll let him handle it

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented May 28, 2020

@houseroad can you please merge this PR. Thanks!

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@houseroad
Copy link
Member

@houseroad houseroad commented May 29, 2020

Sure, will land it soon.

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 2, 2020

@houseroad merged this pull request in 858ab75.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants