Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Argmin/Argmax ONNX Export #38329

Closed
wants to merge 3 commits into from

Conversation

@lara-hdr
Copy link
Member

lara-hdr commented May 12, 2020

Update Argmin/Argmax ONNX export in opset 12 to export with "select_last_index", and export correctly cases where the same value appears multiple time in the input tensor.

lara-hdr added 2 commits May 12, 2020
@dr-ci
Copy link

dr-ci bot commented May 12, 2020

💊 CI failures summary and remediations

As of commit e788f39 (more details on the Dr. CI page):


  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
CONFLICT (add/add): Merge conflict in .circleci/ecr_gc_docker/gc.py 
Auto-merging .circleci/ecr_gc_docker/gc.py 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/codegen_validation/compare_normalized_yaml.sh 
Auto-merging .circleci/codegen_validation/compare_normalized_yaml.sh 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/lib/miniyaml.py 
Auto-merging .circleci/cimodel/lib/miniyaml.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
Automatic merge failed; fix conflicts and then commit the result. 

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
CONFLICT (add/add): Merge conflict in .circleci/ecr_gc_docker/gc.py 
Auto-merging .circleci/ecr_gc_docker/gc.py 
CONFLICT (add/add): Merge conflict in .circleci/config.yml 
Auto-merging .circleci/config.yml 
CONFLICT (add/add): Merge conflict in .circleci/codegen_validation/compare_normalized_yaml.sh 
Auto-merging .circleci/codegen_validation/compare_normalized_yaml.sh 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/lib/miniyaml.py 
Auto-merging .circleci/cimodel/lib/miniyaml.py 
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/windows_build_definitions.py 
Auto-merging .circleci/cimodel/data/windows_build_definitions.py 
Automatic merge failed; fix conflicts and then commit the result. 

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 11 times.

@ezyang ezyang requested a review from houseroad May 13, 2020
@ezyang ezyang added the triaged label May 13, 2020
@lara-hdr lara-hdr requested review from BowenBao and neginraoof and removed request for houseroad May 13, 2020
@neginraoof
Copy link
Collaborator

neginraoof commented May 14, 2020

There's a failure with keypoint_rcnn test. Is this related?

Copy link
Contributor

facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lara-hdr
Copy link
Member Author

lara-hdr commented May 19, 2020

@neginraoof @BowenBao for review.
@houseroad could you please verify if the internal test failures are related?
Thanks

Copy link
Member

houseroad left a comment

Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2020

@houseroad merged this pull request in 9907a3e.

csarofeen added a commit to csarofeen/pytorch that referenced this pull request May 22, 2020
Summary:
Update Argmin/Argmax ONNX export in opset 12 to export with "select_last_index", and export correctly cases where the same value appears multiple time in the input tensor.
Pull Request resolved: pytorch#38329

Reviewed By: hl475

Differential Revision: D21613799

Pulled By: houseroad

fbshipit-source-id: 4597e23561f444c4e56d30c735dae7e9a8a41c5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.