Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Constant Folding Tests #38751

Closed
wants to merge 3 commits into from

Conversation

@KsenijaS
Copy link
Collaborator

KsenijaS commented May 20, 2020

Enable tests for constant folding since constant folding is enabled for opset 12

@KsenijaS KsenijaS changed the title Enable Constant folding tests Enable Constant Folding Tests May 20, 2020
@KsenijaS
Copy link
Collaborator Author

KsenijaS commented May 20, 2020

please review @neginraoof

@dr-ci
Copy link

dr-ci bot commented May 20, 2020

💊 CI failures summary and remediations

As of commit 460f37b (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 6 times.

@KsenijaS
Copy link
Collaborator Author

KsenijaS commented May 20, 2020

@houseroad Failure on CI is not introduced by this PR. Please review

Copy link
Collaborator

neginraoof left a comment

LGTM. Thanks!

@ailzhang ailzhang requested a review from houseroad May 21, 2020
@ailzhang ailzhang added the triaged label May 21, 2020
@KsenijaS
Copy link
Collaborator Author

KsenijaS commented May 26, 2020

@houseroad for review. Thanks!

@ezyang ezyang removed the request for review from houseroad May 26, 2020
@ezyang ezyang removed the triaged label May 26, 2020
Copy link
Contributor

facebook-github-bot left a comment

@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 27, 2020

@ezyang merged this pull request in 0edf063.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.