Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Fix regression disabling checker #39073

Closed
wants to merge 5 commits into from

Conversation

@neginraoof
Copy link
Collaborator

neginraoof commented May 27, 2020

Fix regression disabling checker. Checker should be enabled for ONNX export type only.

neginraoof added 3 commits May 27, 2020
@dr-ci
Copy link

dr-ci bot commented May 27, 2020

💊 CI failures summary and remediations

As of commit 66fbd05 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 9 times.

@gchanan gchanan requested a review from houseroad Jun 1, 2020
@gchanan gchanan added the triaged label Jun 1, 2020
neginraoof added 2 commits Jun 3, 2020
Copy link
Contributor

BowenBao left a comment

LGTM

Copy link
Contributor

facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

houseroad left a comment

Interesting, seems we don't have tests to cover this logic.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 12, 2020

@houseroad merged this pull request in 91d5390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.