Skip to content

Add error message when negative stride is passed to as_strided #39508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

wjgan7
Copy link
Contributor

@wjgan7 wjgan7 commented Jun 4, 2020

Fixes this issue #33290.
Builds upon this PR #33392.

@dr-ci
Copy link

dr-ci bot commented Jun 4, 2020

💊 CI failures summary and remediations

As of commit 3057035 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 11 times.

@wjgan7
Copy link
Contributor Author

wjgan7 commented Jun 4, 2020

Hi @zou3519, could you take a look at this? Also not sure about the tar.headerError's, I did pull before creating the PR (maybe that was a mistake?).

@zou3519
Copy link
Contributor

zou3519 commented Jun 4, 2020

@wjgan7 you've checked in some submodule updates to the pull request. (if you hit files changed, you'll see the following):
image
To undo the submodule updates, you can cd into the submodule's folder (e.g., third_party/onnx) and then checkout the correct commit. (You can see what the correct commits are at https://github.com/pytorch/pytorch/tree/master/third_party)

@zou3519 zou3519 self-requested a review June 4, 2020 19:45
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait for the tests to pass. (If you don't hear from me in a day or two, please feel free to ping me again on the PR)

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@zou3519 merged this pull request in e41fe60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants