-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add error message when negative stride is passed to as_strided #39508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 3057035 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
Hi @zou3519, could you take a look at this? Also not sure about the tar.headerError's, I did pull before creating the PR (maybe that was a mistake?). |
@wjgan7 you've checked in some submodule updates to the pull request. (if you hit files changed, you'll see the following): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's wait for the tests to pass. (If you don't hear from me in a day or two, please feel free to ping me again on the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Fixes this issue #33290.
Builds upon this PR #33392.