Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeypointRCNN test #39589

Closed
wants to merge 4 commits into from
Closed

Fix KeypointRCNN test #39589

wants to merge 4 commits into from

Conversation

@KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Jun 5, 2020

Since Argmax is updated in ONNX Runtime we can enable testing for all output, including keypoints_scores.

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 5, 2020

@neginraoof please review

Loading

@dr-ci
Copy link

@dr-ci dr-ci bot commented Jun 5, 2020

💊 CI failures summary and remediations

As of commit 5b4916c (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 6, 2020

@houseroad please review. Thanks!

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 8, 2020

there is a mismatch between PyTorch and ORT, currently investigating the issue

Loading

@ngimel ngimel requested a review from houseroad Jun 10, 2020
@ngimel ngimel added the triaged label Jun 10, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 11, 2020

@houseroad bug was fixed on the torchvision side: pytorch/vision#2312, test is passing on my local machine.

Loading

@houseroad
Copy link
Member

@houseroad houseroad commented Jun 11, 2020

Do we need to merge the pr in torchvision first? cc: @fmassa

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 11, 2020

@houseroad pr is already merged in torchvision

Loading

@houseroad
Copy link
Member

@houseroad houseroad commented Jun 11, 2020

So will the test pass if we retrigger it?

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 11, 2020

@houseroad I have already retrigger it this morning, it is still failing on the CI but it passes locally.

Loading

@KsenijaS
Copy link
Contributor Author

@KsenijaS KsenijaS commented Jun 16, 2020

@houseroad CI is green. Can we merge this?

Loading

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Loading

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Jun 16, 2020

@houseroad merged this pull request in da8cd82.

Loading

xwang233 added a commit to xwang233/pytorch that referenced this issue Jun 20, 2020
Summary:
Since Argmax is updated in ONNX Runtime we can enable testing for all output, including keypoints_scores.
Pull Request resolved: pytorch#39589

Reviewed By: hl475

Differential Revision: D21992264

Pulled By: houseroad

fbshipit-source-id: a390b4628d2ac290902b9e651c69d47db9be540f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants