New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly check that reduction strings are valid for l1_loss, smoothl1_loss, and mse_loss. #43527
Conversation
…_loss, and mse_loss.
…_loss, and mse_loss. ghstack-source-id: 146614e819a7d4436db70355805865db5269682b Pull Request resolved: #43527
TODO: testing |
💊 CI failures summary and remediationsAs of commit 24b31ac (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
…l1_loss, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786)
…_loss, and mse_loss. ghstack-source-id: 7842029228683947503086172e8a665be9d8a197 Pull Request resolved: #43527
…l1_loss, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786) [ghstack-poisoned]
…_loss, and mse_loss. ghstack-source-id: 9751dfa1e5a2adf6d67319dcace1c937ad0b1705 Pull Request resolved: #43527
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/302/base #43527 +/- ##
=======================================================
+ Coverage 69.33% 69.34% +0.01%
=======================================================
Files 378 378
Lines 46741 46744 +3
=======================================================
+ Hits 32406 32414 +8
+ Misses 14335 14330 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
F.ctc_loss()
is not tested here, is that on purpose?
…s, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786)
good point, I'll add |
Stack from ghstack:
Differential Revision: D23306786