Fixed quantile nan propagation and implemented nanquantile #44393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mruberry
reviewed
Sep 9, 2020
mruberry
reviewed
Sep 9, 2020
mruberry
reviewed
Sep 9, 2020
mruberry
reviewed
Sep 9, 2020
mruberry
reviewed
Sep 9, 2020
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 3eb2102 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 1 failure confirmed as flaky and can be ignored:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 45 times. |
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/heitorschueroff/10/base #44393 +/- ##
===========================================================
Coverage 68.08% 68.08%
===========================================================
Files 384 384
Lines 49774 49776 +2
===========================================================
+ Hits 33890 33892 +2
Misses 15884 15884
Continue to review full report at Codecov.
|
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Differential Revision: [D23649613](https://our.internmc.facebook.com/intern/diff/D23649613) [ghstack-poisoned]
|
@heitorschueroff merged this pull request in 28085cb. |
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #44393 torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile. Test Plan: Imported from OSS Reviewed By: albanD Differential Revision: D23649613 Pulled By: heitorschueroff fbshipit-source-id: 5201d076745ae1237cedc7631c28cf446be99936
loadbxh
pushed a commit
to loadbxh/Torch
that referenced
this pull request
Sep 23, 2020
ghstack-source-id: ce55878 Pull Request resolved: pytorch/pytorch#44393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.quantile now correctly propagates nan and implemented torch.nanquantile similar to numpy.nanquantile.
Differential Revision: D23649613