Add dict() constructor
#51934
Closed
Add dict() constructor
#51934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Feb 9, 2021
ghstack-source-id: 4d210ba5c7e8a014406d8807af4bf8db621517bc Pull Request resolved: #51934
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit 2d5d0f0 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
eellison
approved these changes
Feb 11, 2021
| } | ||
| default: | ||
| TORCH_INTERNAL_ASSERT(false, "unknown special form: ", form); | ||
| if (!apply.inputs().empty() && apply.inputs()[0].kind() == TK_DICT_LITERAL) { |
There was a problem hiding this comment.
IMO, we should get rid of the special empty handling - we're not handling dicts/mappings in general, and dict([]) will work without the special case.
Comment on lines
3171
to
3178
| auto name = StringLiteral::create(kwarg.range(), kwarg.name().name()); | ||
| auto k = emitExpr(name); | ||
| auto v = emitExpr(kwarg.value()); | ||
| NamedValue input_k = NamedValue(kwarg.range(), "", k); | ||
| NamedValue input_v = NamedValue(kwarg.range(), "", v); | ||
| emitBuiltinCall( | ||
| kwarg.range(), *graph, aten::_set_item, {self, input_k, input_v}, {}); | ||
| } |
There was a problem hiding this comment.
This logic is very similar to 3076-3083, you might be able to factor it out to a helper lambda or function
[ghstack-poisoned]
Differential Revision: [D26418199](https://our.internmc.facebook.com/intern/diff/D26418199) [ghstack-poisoned]
Differential Revision: [D26418199](https://our.internmc.facebook.com/intern/diff/D26418199) [ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Feb 12, 2021
ghstack-source-id: 0b55245f9cb6e71e13f3bd9b4614eff7a4b89b09 Pull Request resolved: #51934
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#51934 Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26418199 Pulled By: ansley fbshipit-source-id: 524f6d9d29ee1fa1b7c5e80ada82e577f47089dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
dict()constructor #51934 Adddict()constructorDifferential Revision: D26418199