Adds torch.* API section for TorchScript Lang Ref #53236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 42dd399 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
reviewed
Mar 16, 2021
penguinwu
requested changes
Mar 16, 2021
There was a problem hiding this comment.
Apart from the in-place comments, for consistency, we may want to:
- Specify full signature for all APIs
- Some APIs include a link to a more detailed API description (e.g., is_instanceof()), but others do not. Should we make things consistent to add missing detailed API descriptions to the right places?
- Differentiate decorators and APIs, perhaps add
@in front of decorators?
|
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Codecov Report
@@ Coverage Diff @@
## master #53236 +/- ##
==========================================
- Coverage 77.39% 76.97% -0.42%
==========================================
Files 1897 1897
Lines 187160 187160
==========================================
- Hits 144848 144071 -777
- Misses 42312 43089 +777 |
|
@gmagogsfm merged this pull request in ec609e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.