New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sign
: port to structured
#57588
Closed
Closed
sign
: port to structured
#57588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 1096b52 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 5, 2021
Codecov Report
@@ Coverage Diff @@
## gh/Feey0/2/base #57588 +/- ##
================================================
Coverage 76.91% 76.91%
================================================
Files 1968 1968
Lines 196385 196385
================================================
+ Hits 151049 151056 +7
+ Misses 45336 45329 -7 |
ezyang
approved these changes
May 5, 2021
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mrshenli
pushed a commit
to mrshenli/pytorch
that referenced
this pull request
May 8, 2021
Summary: Pull Request resolved: pytorch#57588 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D28224600 Pulled By: ezyang fbshipit-source-id: 71de5211617c1eba34192e23831136ae5c403e61
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#57588 Test Plan: Imported from OSS Reviewed By: VitalyFedyunin Differential Revision: D28224600 Pulled By: ezyang fbshipit-source-id: 71de5211617c1eba34192e23831136ae5c403e61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ceil
: port to structured #57589 Port ceil to structuredsign
: port to structured #57588 Port sign to structuredfloor
: port to structured #57587 Port floor to structuredDifferential Revision: D28224600