Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign: port to structured #57588

Closed
wants to merge 1 commit into from
Closed

sign: port to structured #57588

wants to merge 1 commit into from

Conversation

Freey0
Copy link
Contributor

@Freey0 Freey0 commented May 5, 2021

Stack from ghstack:

Differential Revision: D28224600

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 5, 2021

💊 CI failures summary and remediations

As of commit 1096b52 (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
GitHub Actions render_test_results Output Test Results (Click Me) 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #57588 (1096b52) into gh/Feey0/2/base (894bbc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           gh/Feey0/2/base   #57588   +/-   ##
================================================
  Coverage            76.91%   76.91%           
================================================
  Files                 1968     1968           
  Lines               196385   196385           
================================================
+ Hits                151049   151056    +7     
+ Misses               45336    45329    -7     

@ezyang
Copy link
Contributor

ezyang commented May 5, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in ccbaa5f.

mrshenli pushed a commit to mrshenli/pytorch that referenced this pull request May 8, 2021
Summary: Pull Request resolved: pytorch#57588

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D28224600

Pulled By: ezyang

fbshipit-source-id: 71de5211617c1eba34192e23831136ae5c403e61
@facebook-github-bot facebook-github-bot deleted the gh/Feey0/2/head branch May 10, 2021 14:17
krshrimali pushed a commit to krshrimali/pytorch that referenced this pull request May 19, 2021
Summary: Pull Request resolved: pytorch#57588

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D28224600

Pulled By: ezyang

fbshipit-source-id: 71de5211617c1eba34192e23831136ae5c403e61
@bdhirsh bdhirsh changed the title Port sign to structured sign: port to structured May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants