Gelu Backward, Contribution from Kevin Stephano #58249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 13, 2021
Closed
Closed
Closed
facebook-github-bot
added
cla signed
oncall: jit
💊 CI failures summary and remediationsAs of commit c09092b (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Krovatkin
added a commit
that referenced
this pull request
May 13, 2021
ghstack-source-id: 2e2fdb43bbd7e01c9e356fdcbb4fb0f5a9ae0486 Pull Request resolved: #58249
[ghstack-poisoned]
Krovatkin
added a commit
that referenced
this pull request
May 13, 2021
ghstack-source-id: e5653a25eaca660de5495159cc0098824322788e Pull Request resolved: #58249
eellison
approved these changes
May 13, 2021
| @@ -1543,6 +1543,12 @@ def sample_inputs_hardswish(self, device, dtype, requires_grad): | |||
| requires_grad=requires_grad, low=-5, high=5)) for _ in range(1, N)] | |||
| return tensors | |||
|
|
|||
| def sample_inputs_gelu(self, device, dtype, requires_grad): | |||
There was a problem hiding this comment.
again, dont think this is actually needed but can be removed in a follow up
| dtypesIfCUDA=floating_types_and(torch.half, torch.bfloat16), | ||
| supports_gradgrad=True, | ||
| supports_out=False, | ||
| autodiff_nonfusible_nodes=["aten::gelu"]), |
There was a problem hiding this comment.
same with this, lets remove this in follow up
|
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
2 similar comments
|
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@Krovatkin merged this pull request in d304bb0. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 14, 2021
Summary: Pull Request resolved: #58249 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D28425629 Pulled By: Krovatkin fbshipit-source-id: 494ab165d548aa76f036344ab1c19c5fd64bae82
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#58249 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D28425381 Pulled By: Krovatkin fbshipit-source-id: 21b7ac972220b6c35b285e3b66f05eb392002408
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Pull Request resolved: pytorch#58249 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D28425629 Pulled By: Krovatkin fbshipit-source-id: 494ab165d548aa76f036344ab1c19c5fd64bae82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D28425629