[RPC Framework] Remote the list for the attributes that will be ignored for pickling #58345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add a sanity check to make sure any new attribute added to the constructor should be added to either `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING` pr `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING`. 2. Update some comments and warning -- now if a new attribute is added after the construction, it will not be pickled. Previously it will trigger a runtime error, which is hard to for unit test. Context: #58019 (comment) Differential Revision: [D28460744](https://our.internmc.facebook.com/intern/diff/D28460744/) [ghstack-poisoned]
wayi1
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit db97316 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
wayi1
pushed a commit
that referenced
this pull request
May 15, 2021
1. Add a sanity check to make sure any new attribute added to the constructor should be added to either `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING` pr `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING`. 2. Update some comments and warning -- now if a new attribute is added after the construction, it will not be pickled. Previously it will trigger a runtime error, which is hard to for unit test. Context: #58019 (comment) Differential Revision: [D28460744](https://our.internmc.facebook.com/intern/diff/D28460744/) ghstack-source-id: 129070358 Pull Request resolved: #58345
wayi1
changed the title
|
This pull request has been merged in 2436377. |
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
…ytorch#58345) Summary: Pull Request resolved: pytorch#58345 1. Add a sanity check to make sure any new attribute added to the constructor should be added to either `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING` pr `_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING`. 2. Update some comments and warning -- now if a new attribute is added after the construction, it will not be pickled. Previously it will trigger a runtime error, which is hard for unit test (one worker hit the runtime error, but the other worker will cause timeout). Context: pytorch#58019 (comment) ghstack-source-id: 129070358 Test Plan: unit test Reviewed By: rohan-varma Differential Revision: D28460744 fbshipit-source-id: 8028186fc447c88fbf2bf57f5c5d321f42ba54ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLINGpr_REMOTE_MODULE_ATTRIBUTES_IGNORE_FOR_PICKLING.Context: [RPC Framework] Replace Python Pickler with internal RPC pickler for RemoteModule #58019 (comment)
Differential Revision: D28460744