Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Validates that weights are 2d in embedding #59314

Closed
wants to merge 2 commits into from
Closed

FIX Validates that weights are 2d in embedding #59314

wants to merge 2 commits into from

Conversation

thomasjpfan
Copy link
Contributor

Fixes #55185

@thomasjpfan thomasjpfan added the module: nn Related to torch.nn label Jun 2, 2021
@thomasjpfan thomasjpfan added this to In Progress in torch.nn via automation Jun 2, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2021 •
edited

💊 CI failures summary and remediations

As of commit ae04d08 (more details on the Dr. CI page):

  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (1/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 02 17:01:07 ../../../../opt/conda/lib/pytho..._test.py::TestCaffe2Basic::test_cast FAILED [ 22%] 
Jun 02 17:01:06 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_2layer_attention PASSED [ 22%]
Jun 02 17:01:06 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_attention PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_multi_decoder PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testAddParam PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testConstuctor PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testGetAllParams PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testGetNonTrainableParams PASSED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTest::test_conv_graph SKIPPED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTest::test_relu_graph SKIPPED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTransformTest::test_resnet50_core SKIPPED [ 22%]
Jun 02 17:01:07 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/tests/c2_ref_test.py::TestCaffe2Basic::test_cast FAILED [ 22%]
Jun 02 17:01:07 
Jun 02 17:01:07 =================================== FAILURES ===================================
Jun 02 17:01:07 __________________________ TestCaffe2Basic.test_cast ___________________________
Jun 02 17:01:07 
Jun 02 17:01:07 self = <caffe2.python.onnx.tests.c2_ref_test.TestCaffe2Basic testMethod=test_cast>
Jun 02 17:01:07 
Jun 02 17:01:07     def test_cast(self):
Jun 02 17:01:07         X = np.random.randn(1, 2, 3).astype(np.float32)
Jun 02 17:01:07     
Jun 02 17:01:07         for to_type in ['INT8', caffe2_pb2.TensorProto.INT8,

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test1 (2/2)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 02 17:01:47 ../../../../opt/conda/lib/pytho..._test.py::TestCaffe2Basic::test_cast FAILED [ 22%] 
Jun 02 17:01:46 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_2layer_attention PASSED [ 22%]
Jun 02 17:01:46 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_attention PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_beam_search_test.py::Seq2SeqBeamSearchTest::test_multi_decoder PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testAddParam PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testConstuctor PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testGetAllParams PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/models/seq2seq/seq2seq_model_helper_test.py::Seq2SeqModelHelperTest::testGetNonTrainableParams PASSED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTest::test_conv_graph SKIPPED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTest::test_relu_graph SKIPPED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/test_onnxifi.py::OnnxifiTransformTest::test_resnet50_core SKIPPED [ 22%]
Jun 02 17:01:47 ../../../../opt/conda/lib/python3.6/site-packages/caffe2/python/onnx/tests/c2_ref_test.py::TestCaffe2Basic::test_cast FAILED [ 22%]
Jun 02 17:01:47 
Jun 02 17:01:47 =================================== FAILURES ===================================
Jun 02 17:01:47 __________________________ TestCaffe2Basic.test_cast ___________________________
Jun 02 17:01:47 
Jun 02 17:01:47 self = <caffe2.python.onnx.tests.c2_ref_test.TestCaffe2Basic testMethod=test_cast>
Jun 02 17:01:47 
Jun 02 17:01:47     def test_cast(self):
Jun 02 17:01:47         X = np.random.randn(1, 2, 3).astype(np.float32)
Jun 02 17:01:47     
Jun 02 17:01:47         for to_type in ['INT8', caffe2_pb2.TensorProto.INT8,

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@thomasjpfan thomasjpfan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 2, 2021
jbschlosser
jbschlosser approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix :)

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

torch.nn automation moved this from In Progress to Done Jun 2, 2021
@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in 7f2e620.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@thomasjpfan @deniskokarev
FIX Validates that weights are 2d in embedding (pytorch#59314)
6931863 
Summary:
Fixes pytorch#55185

Pull Request resolved: pytorch#59314

Reviewed By: H-Huang

Differential Revision: D28837753

Pulled By: jbschlosser

fbshipit-source-id: 683378244c61b0937c95563f91ef87ab09fd1653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
torch.nn
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

F.embedding has unexpected behavior with non-2d weights
4 participants
@thomasjpfan @facebook-github-bot @jbschlosser @pytorchbot