Allow Docker build on macOS #60375
Closed
Allow Docker build on macOS #60375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit a95e3b1 (more details on the Dr. CI page and at hud.pytorch.org/pr/60375):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Similar idea to one of the changes in #58174. |
|
btw ignore the ci/circleci: pytorch_macos_10_15_py3_build failure on this PR, it's unrelated :P |
driazati
approved these changes
Jun 21, 2021
seemethere
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows developers using macOS to build Docker images locally. The
basename $(mktemp -u)part was suggested by @seemethere; I modified it slightly to appease ShellCheck and because Docker doesn't allow uppercase characters in tags.Test plan:
On a Mac: