Add a flag to suppress stacktrace in exception messages #63073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8ce8b39 (more details on the Dr. CI page):
2 failures not recognized by patterns:
1 job timed out:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
|
This pull request was exported from Phabricator. Differential Revision: D30241792 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D30241792 |
d1jang
force-pushed
the
export-D30241792
branch
from
4f380a8
to
c699348
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30241792 |
d1jang
force-pushed
the
export-D30241792
branch
from
c699348
to
b7340b6
Compare
…rch#63073) Summary: Pull Request resolved: pytorch#63073 It turned out that it's less than ideal to print out verbose stacktrace in exception messages in high-QPS services (see the related task) with a non-significant failure rate due to the truncation of long stacktrace which results in losing the original exception message thrown from native code. It is actually desirable to retain only the message of the original exception directly thrown from native code in such a usecase. This change adds a new flag `torch_jit_disable_exception_stacktrace` to the pytorch jit interpreter to suppress stacktrace in the messages of exception thrown from the interpreter. Reviewed By: Krovatkin Differential Revision: D30241792 fbshipit-source-id: fbc90c11e99ab8c1623f016559ad5bfeeaca8465
|
This pull request was exported from Phabricator. Differential Revision: D30241792 |
d1jang
force-pushed
the
export-D30241792
branch
from
b7340b6
to
8ce8b39
Compare
|
This pull request has been merged in 61b49c8. |
alanwaketan
pushed a commit
that referenced
this pull request
Aug 17, 2021
Summary: Pull Request resolved: #63073 It turned out that it's less than ideal to print out verbose stacktrace in exception messages in high-QPS services (see the related task) with a non-significant failure rate due to the truncation of long stacktrace which results in losing the original exception message thrown from native code. It is actually desirable to retain only the message of the original exception directly thrown from native code in such a usecase. This change adds a new flag `torch_jit_disable_exception_stacktrace` to the pytorch jit interpreter to suppress stacktrace in the messages of exception thrown from the interpreter. Reviewed By: Krovatkin Differential Revision: D30241792 fbshipit-source-id: c340225c69286663cbd857bd31ba6f1736b1ac4c
tugsbayasgalan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It turned out that it's less than ideal to print out verbose stacktrace in exception messages in high-QPS services (see the related task) with a non-significant failure rate due to the truncation of long stacktrace which results in losing the original exception message thrown from native code. It is actually desirable to retain only the message of the original exception directly thrown from native code in such a usecase.
This change adds a new flag
torch_jit_disable_exception_stacktraceto the pytorch jit interpreter to suppress stacktrace in the messages of exception thrown from the interpreter.Differential Revision: D30241792