-
Notifications
You must be signed in to change notification settings - Fork 24.7k
Add quantized::mul nnapi converter #63913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 77115e0 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: As Title Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_qadd Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30531890](https://our.internmc.facebook.com/intern/diff/D30531890) [ghstack-poisoned]
Summary: As Title Test Plan: pytest test/test_nnapi.py::TestNNAPI::test_qadd Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30531890](https://our.internmc.facebook.com/intern/diff/D30531890) [ghstack-poisoned]
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
def forward(self, lhs, rhs): | ||
return func.mul(lhs, rhs) | ||
|
||
for (name, mod) in [("add", AddMod), ("add_relu", AddReluMod), ("mul", MulMod)]: | ||
with self.subTest(name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do subTest(mod.__name__):
to reduce the boilerplate here.
Stack from ghstack:
Summary:
As Title
Test Plan:
pytest test/test_nnapi.py::TestNNAPI::test_qadd
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D30531890