Extend 2Dim embedding bag benchmarking to include 3Dim benchmarks #64647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2c667ff (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D30770085 |
Codecov Report
@@ Coverage Diff @@
## master #64647 +/- ##
===========================================
+ Coverage 53.70% 66.64% +12.94%
===========================================
Files 710 710
Lines 92426 92426
===========================================
+ Hits 49638 61601 +11963
+ Misses 42788 30825 -11963 |
jingsh
reviewed
Sep 8, 2021
Sounds good to me! |
|
This pull request was exported from Phabricator. Differential Revision: D30770085 |
EdwaRen
force-pushed
the
export-D30770085
branch
from
2eb0a1c
to
d706a12
Compare
…torch#64647) Summary: Pull Request resolved: pytorch#64647 Add support for benchmarking of 8 bit quantizations of N-D batched embeddings. Currently only works for 3Dim embeddings and still requires thought on ramping up from 3Dim to NDim. Test Plan: ```buck run //caffe2/benchmarks/operator_benchmark/pt:qembedding_pack_test``` Differential Revision: D30770085 fbshipit-source-id: e46bf09057347dd9d391d2d4f7468b7a0c46aabc
|
This pull request was exported from Phabricator. Differential Revision: D30770085 |
EdwaRen
force-pushed
the
export-D30770085
branch
from
d706a12
to
2c667ff
Compare
jingsh
approved these changes
Sep 9, 2021
|
This pull request has been merged in 3fbb49e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for benchmarking of 8 bit quantizations of N-D batched embeddings. Currently only works for 3Dim embeddings and still requires thought on ramping up from 3Dim to NDim.
Test Plan:
buck run //caffe2/benchmarks/operator_benchmark/pt:qembedding_pack_testDifferential Revision: D30770085