model_dump: Fix memory computation when both constants and data tensors are present #66006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs are present Previously, this was resulting in a key collision and a crash. Differential Revision: [D31281092](https://our.internmc.facebook.com/intern/diff/D31281092/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c805a1a (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 linux-bionic-py3.6-clang9 / test (default, 1, 2, linux.2xlarge) |
Unknown | 🔁 rerun |
| linux-xenial-py3.6-gcc5.4 / test (default, 1, 2, linux.2xlarge) |
Unknown | 🔁 rerun |
| linux-xenial-py3.6-gcc5.4 / test (default, 2, 2, linux.2xlarge) |
Unknown | 🔁 rerun |
❄️ 3 failures tentatively classified as flaky
but reruns have not yet been triggered to confirm:
linux-xenial-py3.6-gcc5.4 / build-docs (cpp) (1/3)
Step: "Build cpp docs" (full log | diagnosis details | 🔁 rerun) ❄️
2021-10-01T17:07:19.6888195Z E: Failed to fetch...: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-01T17:07:19.6472633Z
2021-10-01T17:07:19.6472967Z Reading package lists... 99%
2021-10-01T17:07:19.6473202Z
2021-10-01T17:07:19.6660247Z Reading package lists... 99%
2021-10-01T17:07:19.6660615Z
2021-10-01T17:07:19.6660932Z Reading package lists... Done
2021-10-01T17:07:19.6661179Z
2021-10-01T17:07:19.6884757Z W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
2021-10-01T17:07:19.6885904Z N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
2021-10-01T17:07:19.6886810Z N: See apt-secure(8) manpage for repository creation and user configuration details.
2021-10-01T17:07:19.6888195Z E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-01T17:07:19.6889291Z E: Some index files failed to download. They have been ignored, or old ones used instead.
2021-10-01T17:07:19.6962271Z
2021-10-01T17:07:19.7399942Z Reading package lists... 0%
2021-10-01T17:07:19.7400469Z
2021-10-01T17:07:19.7504951Z Reading package lists... 0%
2021-10-01T17:07:19.7505797Z
2021-10-01T17:07:19.7955197Z Reading package lists... 1%
2021-10-01T17:07:19.7955519Z
2021-10-01T17:07:19.7955911Z Reading package lists... 8%
2021-10-01T17:07:19.7956148Z
linux-xenial-py3.6-gcc5.4 / build-docs (python) (2/3)
Step: "Unknown" (full log | diagnosis details | 🔁 rerun) ❄️
2021-10-01T17:07:20.9876318Z E: Failed to fetch...: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-01T17:07:20.9446690Z
2021-10-01T17:07:20.9447032Z Reading package lists... 99%
2021-10-01T17:07:20.9447288Z
2021-10-01T17:07:20.9640281Z Reading package lists... 99%
2021-10-01T17:07:20.9640603Z
2021-10-01T17:07:20.9640932Z Reading package lists... Done
2021-10-01T17:07:20.9641190Z
2021-10-01T17:07:20.9872594Z W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
2021-10-01T17:07:20.9873839Z N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
2021-10-01T17:07:20.9874866Z N: See apt-secure(8) manpage for repository creation and user configuration details.
2021-10-01T17:07:20.9876318Z E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-01T17:07:20.9877600Z E: Some index files failed to download. They have been ignored, or old ones used instead.
2021-10-01T17:07:20.9951322Z
2021-10-01T17:07:21.0386744Z Reading package lists... 0%
2021-10-01T17:07:21.0387274Z
2021-10-01T17:07:21.0491940Z Reading package lists... 0%
2021-10-01T17:07:21.0492461Z
2021-10-01T17:07:21.0941397Z Reading package lists... 1%
2021-10-01T17:07:21.0941922Z
2021-10-01T17:07:21.0942474Z Reading package lists... 8%
2021-10-01T17:07:21.0942917Z
pytorch_linux_xenial_py3_6_gcc5_4_test (3/3)
Step: "Check for no AVX instruction by default" (full log | diagnosis details | 🔁 rerun) ❄️
E: Failed to fetch https://deb.nodesource.com/n...: /etc/ssl/certs/ca-certificates.crt CRLfile: none
Ign:11 https://deb.nodesource.com/node_12.x xenial/main Sources
Ign:16 https://deb.nodesource.com/node_12.x xenial/main amd64 Packages
Ign:14 https://deb.nodesource.com/node_12.x xenial/main all Packages
Err:11 https://deb.nodesource.com/node_12.x xenial/main Sources
server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
Ign:16 https://deb.nodesource.com/node_12.x xenial/main amd64 Packages
Ign:14 https://deb.nodesource.com/node_12.x xenial/main all Packages
Fetched 4466 kB in 4s (1099 kB/s)
Reading package lists...
W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
E: Some index files failed to download. They have been ignored, or old ones used instead.
Exited with code exit status 100
🚧 1 fixed upstream failure:
These were probably caused by upstream breakages that were already fixed.
Please rebase on the viable/strict branch (expand for instructions)
If your commit is older than viable/strict, run these commands:
git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
- linux-xenial-cuda11.3-py3.6-gcc7 / build on Oct 01 from 9:17am to 9:48am (21da6ae - 21da6ae)
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
dreiss
added a commit
that referenced
this pull request
Oct 1, 2021
…rs are present Previously, this was resulting in a key collision and a crash. Differential Revision: [D31281092](https://our.internmc.facebook.com/intern/diff/D31281092/) ghstack-source-id: 139342089 Pull Request resolved: #66006
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Previously, this was resulting in a key collision and a crash.
Differential Revision: D31281092