Fix documentation of arguments for torch.nn.functional.Linear #66884

mikaylagawarecki · 2021-10-19T17:58:32Z

Stack from ghstack:

-> Fix documentation of arguments for torch.nn.functional.Linear #66884

Addressing docs fix mentioned in issue #64978 on Github

Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/

)

Addressing docs fix mentioned in issue 64978 on Github Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/) [ghstack-poisoned]

facebook-github-bot · 2021-10-19T17:58:34Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/66884
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit a93a670 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2021-10-20T15:46:23.0513236Z The PR is introduc...m to confirm whether this change is wanted or not.

2021-10-20T15:46:23.0500582Z processing existing schema:  alltoall_base(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor _1, Tensor _2, int[] _3, int[] _4) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0501881Z processing existing schema:  alltoall(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, Tensor[] _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0503138Z processing existing schema:  send(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0504380Z processing existing schema:  recv(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0505640Z processing existing schema:  recv_anysource(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0506867Z processing existing schema:  barrier(__torch__.torch.classes.dist_c10d.ProcessGroup _0) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-20T15:46:23.0507898Z processing existing schema:  __init__(__torch__.torch.classes.dist_c10d.frontend _0) -> (NoneType _0)
2021-10-20T15:46:23.0509248Z processing existing schema:  new_process_group_helper(__torch__.torch.classes.dist_c10d.frontend _0, int _1, int _2, int[] _3, str _4, __torch__.torch.classes.dist_c10d.Store _5, str? _6, int _7) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
2021-10-20T15:46:23.0510754Z processing existing schema:  get_process_group_by_name(__torch__.torch.classes.dist_c10d.frontend _0, str _1) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
2021-10-20T15:46:23.0512122Z processing existing schema:  get_name_of_process_group(__torch__.torch.classes.dist_c10d.frontend _0, __torch__.torch.classes.dist_c10d.ProcessGroup _1) -> (str _0)
2021-10-20T15:46:23.0513236Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2021-10-20T15:46:23.0513811Z 
2021-10-20T15:46:23.0514077Z Broken ops: [
2021-10-20T15:46:23.0514674Z 	prim::TensorExprDynamicGuard(...) -> (bool)
2021-10-20T15:46:23.0515072Z ]
2021-10-20T15:46:23.0659314Z + cleanup
2021-10-20T15:46:23.0659641Z + retcode=1
2021-10-20T15:46:23.0659915Z + set +x
2021-10-20T15:46:23.0660247Z =================== sccache compilation log ===================
2021-10-20T15:46:23.0849156Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2021-10-20T15:46:23.0868838Z Compile requests                      0

Test tools / test (2/2)

Step: "Test tools" (full log | diagnosis details | 🔁 rerun)

2021-10-20T15:37:15.9446280Z AssertionError: 'x...ck (most recent call last):\n Fil[154 chars]\'\n'

2021-10-20T15:37:15.9437745Z   File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/unittest/async_case.py", line 65, in _callTestMethod
2021-10-20T15:37:15.9438530Z     self._callMaybeAsync(method)
2021-10-20T15:37:15.9439362Z   File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/unittest/async_case.py", line 88, in _callMaybeAsync
2021-10-20T15:37:15.9440272Z     return self._asyncioTestLoop.run_until_complete(fut)
2021-10-20T15:37:15.9441200Z   File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/asyncio/base_events.py", line 641, in run_until_complete
2021-10-20T15:37:15.9441954Z     return future.result()
2021-10-20T15:37:15.9442782Z   File "/opt/hostedtoolcache/Python/3.10.0/x64/lib/python3.10/unittest/async_case.py", line 102, in _asyncioLoopRunner
2021-10-20T15:37:15.9443531Z     ret = await awaitable
2021-10-20T15:37:15.9444243Z   File "/home/runner/work/pytorch/pytorch/tools/test/test_actions_local_runner.py", line 187, in test_mypy
2021-10-20T15:37:15.9445039Z     self.assertEqual(expected, f.getvalue())
2021-10-20T15:37:15.9446280Z AssertionError: 'x my[29 chars]on)\ntorch/some_stubs.pyi:3:17: error: Incompa[788 chars]t]\n' != 'x my[29 chars]on)\nTraceback (most recent call last):\n  Fil[154 chars]\'\n'
2021-10-20T15:37:15.9447174Z   x mypy (skipped typestub generation)
2021-10-20T15:37:15.9447870Z + Traceback (most recent call last):
2021-10-20T15:37:15.9448547Z +   File "/home/runner/work/pytorch/pytorch/tools/linter/mypy_wrapper.py", line 27, in <module>
2021-10-20T15:37:15.9449181Z +     import mypy.api
2021-10-20T15:37:15.9450360Z + ModuleNotFoundError: No module named 'mypy'
2021-10-20T15:37:15.9451515Z - torch/some_stubs.pyi:3:17: error: Incompatible types in assignment (expression has type "None", variable has type "str")  [assignment]
2021-10-20T15:37:15.9452907Z - torch/some_stubs.pyi:4:17: error: Incompatible types in assignment (expression has type "float", variable has type "str")  [assignment]
2021-10-20T15:37:15.9454292Z - torch/some_cool_file.py:3:17: error: Incompatible types in assignment (expression has type "None", variable has type "str")  [assignment]
2021-10-20T15:37:15.9455690Z - torch/some_cool_file.py:4:17: error: Incompatible types in assignment (expression has type "float", variable has type "str")  [assignment]
2021-10-20T15:37:15.9457106Z - caffe2/some_cool_file.py:3:17: error: Incompatible types in assignment (expression has type "None", variable has type "str")  [assignment]

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

pytorch-probot · 2021-10-19T17:58:35Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/a93a6703c8583bd9e00ec68a990afdb7c058a347/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/xla`	✅ triggered
linux-vulkan-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-dynamic	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`	✅ triggered
linux-xenial-py3.6-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`	✅ triggered
linux-xenial-py3.6-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`	✅ triggered
linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/win`	✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
linux-xenial-py3-clang5-mobile-code-analysis	`ciflow/all`, `ciflow/linux`, `ciflow/mobile`	🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

…ear" Addressing docs fix mentioned in issue 64978 on Github Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/) [ghstack-poisoned]

Pull Request resolved: #66884 Addressing docs fix mentioned in issue 64978 on Github ghstack-source-id: 140998641 Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/)

jbschlosser

Thanks for the update! Changes look great - just a couple tiny tweaks needed and we're good to go :)

torch/nn/functional.py

…ear" Addressing docs fix mentioned in issue #64978 on Github Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/ <img width="745" alt="Screen Shot 2021-10-19 at 2 29 59 PM" src="https://user-images.githubusercontent.com/35276741/137971953-759dab17-df24-4fbb-8d2a-c3a37d763b57.png"> ) [ghstack-poisoned]

Pull Request resolved: #66884 Addressing docs fix mentioned in issue 64978 on Github ghstack-source-id: 141093449 Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/)

jbschlosser

LGTM! :)

Summary: Pull Request resolved: #66884 Addressing docs fix mentioned in issue 64978 on Github ghstack-source-id: 141093449 Test Plan: https://pxl.cl/1Rxkz Reviewed By: anjali411 Differential Revision: D31767303 fbshipit-source-id: f1ca10fed5bb768749bce3ddc240bbce1dfb3f84

Fix documentation of arguments for torch.nn.functional.Linear

a51bcbb

Addressing docs fix mentioned in issue 64978 on Github Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/) [ghstack-poisoned]

mikaylagawarecki requested review from albanD and jbschlosser as code owners October 19, 2021 17:58

pytorch-probot bot added the ciflow/default label Oct 19, 2021

facebook-github-bot added the cla signed label Oct 19, 2021

mikaylagawarecki removed request for albanD and jbschlosser October 19, 2021 17:59

Update on "Fix documentation of arguments for torch.nn.functional.Lin…

4f27df3

…ear" Addressing docs fix mentioned in issue 64978 on Github Differential Revision: [D31767303](https://our.internmc.facebook.com/intern/diff/D31767303/) [ghstack-poisoned]

mikaylagawarecki requested a review from jbschlosser October 19, 2021 18:46

jbschlosser reviewed Oct 20, 2021

View reviewed changes

torch/nn/functional.py Outdated Show resolved Hide resolved

torch/nn/functional.py Outdated Show resolved Hide resolved

mikaylagawarecki requested a review from jbschlosser October 20, 2021 15:29

jbschlosser approved these changes Oct 20, 2021

View reviewed changes

facebook-github-bot closed this Oct 20, 2021

facebook-github-bot deleted the gh/mikaylagawarecki/4/head branch November 20, 2021 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix documentation of arguments for torch.nn.functional.Linear #66884

Fix documentation of arguments for torch.nn.functional.Linear #66884

Uh oh!

mikaylagawarecki commented Oct 19, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Oct 19, 2021 •

edited

Loading

Uh oh!

pytorch-probot bot commented Oct 19, 2021 •

edited

Loading

⚛️ CI Flow

Uh oh!

jbschlosser left a comment

Uh oh!

Uh oh!

Uh oh!

jbschlosser left a comment

Uh oh!

Uh oh!

Fix documentation of arguments for torch.nn.functional.Linear #66884

Fix documentation of arguments for torch.nn.functional.Linear #66884

Uh oh!

Conversation

mikaylagawarecki commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/2)

Test tools / test (2/2)

Uh oh!

pytorch-probot bot commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

jbschlosser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jbschlosser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mikaylagawarecki commented Oct 19, 2021 •

edited

Loading

facebook-github-bot commented Oct 19, 2021 •

edited

Loading

pytorch-probot bot commented Oct 19, 2021 •

edited

Loading