[PyTorch][Static Runtime] Support memory planning for to without requiring copying#67223
Closed
swolchok wants to merge 42 commits into
Closed
[PyTorch][Static Runtime] Support memory planning for to without requiring copying#67223swolchok wants to merge 42 commits into
swolchok wants to merge 42 commits into
Conversation
… requiring copying Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 9e9d020 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
facebook-github-bot
added
the
oncall: jit
This was referenced Oct 25, 2021
swolchok
added a commit
that referenced
this pull request
Oct 25, 2021
… requiring copying Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) ghstack-source-id: 141496824 Pull Request resolved: #67223
eellison
reviewed
Oct 26, 2021
eellison
left a comment
eellison
left a comment
Contributor
There was a problem hiding this comment.
@navahgar is working on a first invocation of SR that would give dtype/device on the tensors after that we should be able to statically tell whether to is a no-op or will copy. would it be easier to integrate with those changes than add all this ?
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 27, 2021
… requiring copying Pull Request resolved: #67223 ghstack-source-id: 141748858 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
This was referenced Nov 2, 2021
swolchok
added a commit
that referenced
this pull request
Nov 2, 2021
… requiring copying Pull Request resolved: #67223 ghstack-source-id: 142215025 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
This was referenced Nov 10, 2021
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Dec 1, 2021
…requiring copying Pull Request resolved: #67223 ghstack-source-id: 144507292 Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/)
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
This was referenced Dec 13, 2021
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
… to without requiring copying" Differential Revision: [D31776259](https://our.internmc.facebook.com/intern/diff/D31776259/) [ghstack-poisoned]
swolchok
changed the title
wconstab
pushed a commit
that referenced
this pull request
Jan 5, 2022
…requiring copying (#67223) Summary: Pull Request resolved: #67223 ghstack-source-id: 146482215 Test Plan: See perf measurements on ctr_mobile_feed local_ro net for this stack: P467203421 (local is neutral: P467267554) Reviewed By: hlu1 Differential Revision: D31776259 fbshipit-source-id: f84fcaa05029577213f3bf2ae9d4b987b68480b3
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 25, 2026
…requiring copying (pytorch#67223) Summary: Pull Request resolved: pytorch#67223 ghstack-source-id: 146482215 Test Plan: See perf measurements on ctr_mobile_feed local_ro net for this stack: P467203421 (local is neutral: P467267554) Reviewed By: hlu1 Differential Revision: D31776259 fbshipit-source-id: f84fcaa05029577213f3bf2ae9d4b987b68480b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31776259