[Pytorch Edge] Make More Classes Selective #67397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 429f713 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
JacobSzwejbka
added a commit
that referenced
this pull request
Oct 27, 2021
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! ghstack-source-id: 141752876 Pull Request resolved: #67397
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
JacobSzwejbka
added a commit
that referenced
this pull request
Oct 28, 2021
Pull Request resolved: #67397 ghstack-source-id: 141782217 Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)!
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
JacobSzwejbka
added a commit
that referenced
this pull request
Oct 28, 2021
Pull Request resolved: #67397 ghstack-source-id: 141821841 Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)!
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
JacobSzwejbka
added a commit
that referenced
this pull request
Oct 29, 2021
Pull Request resolved: #67397 Expand selectivity coverage to classes created outside of TORCH_LIBRARY. ghstack-source-id: 141938511 Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)!
Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)! [ghstack-poisoned]
JacobSzwejbka
added a commit
that referenced
this pull request
Nov 1, 2021
Pull Request resolved: #67397 Expand selectivity coverage to classes created outside of TORCH_LIBRARY. ghstack-source-id: 142076940 Differential Revision: [D31978965](https://our.internmc.facebook.com/intern/diff/D31978965/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31978965/)!
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2021
Summary: Pull Request resolved: #67397 Expand selectivity coverage to classes created outside of TORCH_LIBRARY. ghstack-source-id: 142076940 Test Plan: Model unit tests, manually run some models on prod apps. Reviewed By: dhruvbird, bdhirsh Differential Revision: D31978965 fbshipit-source-id: 708901b47a9838ac54c78788028d0e18c1e378c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D31978965
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!