[PyTorch Edge][QNNPack] Depthwise Conv3d mp8x27 (per channel) Neon Kernel #69313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnel Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 4e77eba (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Dec 2, 2021
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
…el) Neon Kernel" Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py Differential Revision: [D32074096](https://our.internmc.facebook.com/intern/diff/D32074096/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D32074096/)! [ghstack-poisoned]
wconstab
pushed a commit
that referenced
this pull request
Jan 5, 2022
…rnel (#69313) Summary: Pull Request resolved: #69313 Allows for depthwise conv3d with 3x3x3 kernel Implementation based heavily off of [mp8x25-neon-per-channel.c](https://www.internalfb.com/code/fbsource/[679135d62c0a64e3d0fa0c830aa062ac28f292b8]/fbcode/caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/src/q8dwconv/mp8x25-neon-per-channel.c) (depthwise conv2d with 5x5 kernel) This supports per-channel convolution, but it works for non per-channel too Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with - cd caffe2/aten/src/ATen/native/quantized/cpu/qnnpack - python3 generate-wrapper.py ghstack-source-id: 146346785 Test Plan: Test when used in depthwise conv3d later in this diff stack (D31966574) Reviewed By: kimishpatel Differential Revision: D32074096 fbshipit-source-id: 8111926df6ecb89d88ca810deeab87b1c072f55a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Allows for depthwise conv3d with 3x3x3 kernel
Implementation based heavily off of mp8x25-neon-per-channel.c (depthwise conv2d with 5x5 kernel)
This supports per-channel convolution, but it works for non per-channel too
Generated files (caffe2/aten/src/ATen/native/quantized/cpu/qnnpack/wrappers/q8dwconv/*) made with
Differential Revision: D32074096
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!