Release GIL during RPC shutdown. #69586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain scenarios during shutdown the following assert failed: https://github.com/pytorch/pytorch/blob/master/torch/csrc/distributed/rpc/rpc_agent.cpp#L39. This was due to _reset_current_rpc_agent not releasing GIL. Fixed this issue by releasing GIL. Differential Revision: [D32937687](https://our.internmc.facebook.com/intern/diff/D32937687/) [ghstack-poisoned]
pritamdamania87
requested review from
bowangbj,
H-Huang,
mingzhe09088,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 13546f6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
cla signed
oncall: distributed
pritamdamania87
pushed a commit
that referenced
this pull request
Dec 8, 2021
In certain scenarios during shutdown the following assert failed: https://github.com/pytorch/pytorch/blob/master/torch/csrc/distributed/rpc/rpc_agent.cpp#L39. This was due to _reset_current_rpc_agent not releasing GIL. Fixed this issue by releasing GIL. Differential Revision: [D32937687](https://our.internmc.facebook.com/intern/diff/D32937687/) ghstack-source-id: 145062265 Pull Request resolved: #69586
desertfire
pushed a commit
that referenced
this pull request
Dec 13, 2021
Summary: Pull Request resolved: #69586 In certain scenarios during shutdown the following assert failed: https://github.com/pytorch/pytorch/blob/master/torch/csrc/distributed/rpc/rpc_agent.cpp#L39. This was due to _reset_current_rpc_agent not releasing GIL. Fixed this issue by releasing GIL. ghstack-source-id: 145062265 Test Plan: waitforbuildbot Reviewed By: mrshenli Differential Revision: D32937687 fbshipit-source-id: 980adbcc1e3799b40206f7bca6e7695ca67f0fc2
desertfire
pushed a commit
that referenced
this pull request
Dec 14, 2021
Summary: Pull Request resolved: #69586 In certain scenarios during shutdown the following assert failed: https://github.com/pytorch/pytorch/blob/master/torch/csrc/distributed/rpc/rpc_agent.cpp#L39. This was due to _reset_current_rpc_agent not releasing GIL. Fixed this issue by releasing GIL. ghstack-source-id: 145062265 Test Plan: waitforbuildbot Reviewed By: mrshenli Differential Revision: D32937687 fbshipit-source-id: 980adbcc1e3799b40206f7bca6e7695ca67f0fc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In certain scenarios during shutdown the following assert failed:
https://github.com/pytorch/pytorch/blob/master/torch/csrc/distributed/rpc/rpc_agent.cpp#L39.
This was due to _reset_current_rpc_agent not releasing GIL.
Fixed this issue by releasing GIL.
Differential Revision: D32937687
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @SciPioneer @H-Huang