Remove backward ops for cuDNN transposed convolution #69902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
jbschlosser
requested review from
albanD,
ezyang and
soulitzer
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 67f76a9 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
albanD
reviewed
Dec 14, 2021
| @@ -4763,6 +4763,22 @@ std::tuple<Tensor, Tensor> _cudnn_convolution_backward( | |||
| return result; | |||
| } | |||
|
|
|||
| std::tuple<Tensor, Tensor> _cudnn_convolution_transpose_backward( | |||
There was a problem hiding this comment.
Can we re-use the op from above with an extra boolean argument for transpose?
Differential Revision: [D33093795](https://our.internmc.facebook.com/intern/diff/D33093795) [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
Dec 14, 2021
ghstack-source-id: 23aaaabb4ad0e579be50e44abd804fc5c271d895 Pull Request resolved: #69902
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33093795](https://our.internmc.facebook.com/intern/diff/D33093795) [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
Dec 14, 2021
ghstack-source-id: 46cf61dd8e77d3c82fcecf4bc4cca5b81248c742 Pull Request resolved: #69902
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33093795](https://our.internmc.facebook.com/intern/diff/D33093795) [ghstack-poisoned]
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33093795](https://our.internmc.facebook.com/intern/diff/D33093795) [ghstack-poisoned]
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D33093795](https://our.internmc.facebook.com/intern/diff/D33093795) [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
Dec 15, 2021
ghstack-source-id: 5acebf79e6819baab2b8086359327c9f19dee081 Pull Request resolved: #69902
|
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D33093795