Consolidate the naming of named_parameter and state_dict for CheckpointWrapper #80089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntWrapper named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/) [ghstack-poisoned]
fegin
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu and
mingzhe09088
as code owners
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 56150c9 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
fegin
added a commit
that referenced
this pull request
Jun 22, 2022
…ntWrapper named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/) ghstack-source-id: 159696213 Pull Request resolved: #80089
facebook-github-bot
added
the
oncall: distributed
rohan-varma
reviewed
Jun 23, 2022
| Overrides :meth:`named_parameters()` to intercept parameter names and | ||
| remove all occurrences of _CHECKPOINT_PREFIX. | ||
| """ | ||
| # Determine which logic to use based on the context at call time |
There was a problem hiding this comment.
nit: there is no context here?
…or CheckpointWrapper" named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jun 23, 2022
…ntWrapper Pull Request resolved: #80089 named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. ghstack-source-id: 159744641 Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/)
…or CheckpointWrapper" named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jun 30, 2022
…ntWrapper Pull Request resolved: #80089 named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. ghstack-source-id: 160471938 Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/)
…or CheckpointWrapper" named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jul 5, 2022
…ntWrapper Pull Request resolved: #80089 named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. ghstack-source-id: 160637693 Differential Revision: [D37344200](https://our.internmc.facebook.com/intern/diff/D37344200/)
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @fegin. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
…ntWrapper (#80089) (#80089) Summary: named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue. Pull Request resolved: #80089 Approved by: https://github.com/rohan-varma Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e0eeb06ec6b047eaa9ec7d9d08debd636dffb9a2 Reviewed By: mehtanirav Differential Revision: D37344200 Pulled By: fegin fbshipit-source-id: e4ae3136d68114bff548f3f1774356a30515047d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
named_parameter() should return the same parameter names as state_dict() but the current CheckpointWrapper does not enforce this naming rule. This PR resolves this issue.
Differential Revision: D37344200