[FSDP] Refactor comm hooks directory #85496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
mingzhe09088,
H-Huang and
awgu
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85496
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit d71267b: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Sep 22, 2022
Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/) ghstack-source-id: 168200563 Pull Request resolved: #85496
Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Sep 22, 2022
Pull Request resolved: #85496 Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace ghstack-source-id: 168203289 Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/)
Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Sep 22, 2022
Pull Request resolved: #85496 Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace ghstack-source-id: 168203649 Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/)
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace. Also a few small refactors. Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/) [ghstack-poisoned]
This was referenced Oct 6, 2022
rohan-varma
added a commit
that referenced
this pull request
Oct 6, 2022
Pull Request resolved: #85496 Move FSDP comm hooks into FSDP folder, expose the reduced precision hooks in torch.distributed.fsdp.default_comm_hooks namespace ghstack-source-id: 93958491eb946b798364f34c7c3953317e8ef71f Differential Revision: [D39743042](https://our.internmc.facebook.com/intern/diff/D39743042/)
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Move FSDP comm hooks into FSDP folder, expose the reduced precision
hooks in torch.distributed.fsdp.default_comm_hooks namespace. Also a few small refactors.
Differential Revision: D39743042
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu