Try to fix shutdown test in edge cases #86464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86464
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No Failures, 2 PendingAs of commit 9b1ca6f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
Chillee,
Krovatkin,
anjali411,
antoniojkim,
bdhirsh,
ezyang,
miladm and
wconstab
albanD
requested review from
soulitzer
and removed request for
Chillee,
Krovatkin,
antoniojkim,
bdhirsh,
miladm and
wconstab
Collaborator
Author
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ezyang
approved these changes
Oct 7, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
Summary: Fixes #85259 See the issue for debugging details. tl;dr: when a worker thread is actually used, make sure it is initialized before exiting. Yes, it is very unlikely it will take >10s to initialize but it is what seems to happen. Pull Request resolved: #86464 Approved by: https://github.com/soulitzer, https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/97e56c176d6091a91ac2afe284fc8cb406780ddd Reviewed By: seemethere Differential Revision: D40197230 Pulled By: seemethere fbshipit-source-id: e4c4bf13a3743ff9ed5962871f8490549e2208d0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85259
See the issue for debugging details.
tl;dr: when a worker thread is actually used, make sure it is initialized before exiting.
Yes, it is very unlikely it will take >10s to initialize but it is what seems to happen.