Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling logging.basicConfig #86959

Closed
wants to merge 2 commits into from
Closed

Avoid calling logging.basicConfig #86959

wants to merge 2 commits into from

Conversation

SherlockNoMad
Copy link
Contributor

@SherlockNoMad SherlockNoMad commented Oct 14, 2022 •
edited by pytorchmergebot
Loading

Fixes #85952

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86959

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d871165:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 14, 2022
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/SherlockNoMad/46/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/86959)

pytorchmergebot pushed a commit that referenced this pull request Oct 14, 2022
@SherlockNoMad
Avoid calling logging.basicConfig
22ac579 
ghstack-source-id: 3f966f8636365aaec0e102f6eb3fadb45afe2fe8
Pull Request resolved: #86959
xwang233
xwang233 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@xwang233 xwang233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 14, 2022
@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
penguinwu, janeyx99, 842974287, fegin, chandlerzuo, ...

Details for Dev Infra team Raised by workflow job

@SherlockNoMad
Copy link
Contributor Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @SherlockNoMad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

atalman pushed a commit to atalman/pytorch that referenced this pull request Oct 21, 2022
@SherlockNoMad @atalman
Avoid calling logging.basicConfig (pytorch#86959)
43a6cc1 
Fixes pytorch#85952

Pull Request resolved: pytorch#86959
Approved by: https://github.com/xwang233, https://github.com/davidberard98
This was referenced Oct 21, 2022
Merged
Closed
atalman added a commit that referenced this pull request Oct 21, 2022
@atalman @SherlockNoMad
Avoid calling logging.basicConfig (#86959) (#87455)
d253eb2 
Fixes #85952

Pull Request resolved: #86959
Approved by: https://github.com/xwang233, https://github.com/davidberard98

Co-authored-by: Sherlock Huang <bahuang@fb.com>
@malfet malfet mentioned this pull request Nov 23, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/SherlockNoMad/46/head branch June 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwang233 xwang233 xwang233 approved these changes

@davidberard98 davidberard98 davidberard98 approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SherlockNoMad @pytorchmergebot @davidberard98 @xwang233