Move PadNd from ATen/native to ATen #87456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This header is being included from both aten/native and torch/csrc, but some of our build configurations don't allow direct dependencies from torch/csrc to atent/native, so put the header in aten where it's always accessible. Resolves pytorch#81198 Test Plan: CI. ``` ./scripts/build_android.sh env ANDROID_ABI="x86_64" ANDROID_NDK=".../ndk-bundle" CMAKE_CXX_COMPILER_LAUNCHER=ccache CMAKE_C_COMPILER_LAUNCHER=ccache USE_VULKAN=0 ./scripts/build_android.sh echo '#include <torch/torch.h>' > test.cpp g++ -E -I $PWD/build_android/install/include/ -I $PWD/build_android/install/include/torch/csrc/api/include test.cpp >/dev/null ``` ghstack-source-id: 8f6f1b9954cd3ae5399db7a0bfe0d5ba70d39823 Pull Request resolved: pytorch#82379
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87456
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit d5c3920: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seemethere
approved these changes
Oct 21, 2022
malfet
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This header is being included from both aten/native and torch/csrc, but some of our build configurations don't allow direct dependencies from torch/csrc to atent/native, so put the header in aten where it's always accessible.
Resolves #81198
Test Plan:
CI.
ghstack-source-id: 8f6f1b9954cd3ae5399db7a0bfe0d5ba70d39823
Pull Request resolved: #82379