Reenable isinstance with torch.distributed.ReduceOp (#87303)
#87463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tentatively marking as draft as I haven't gotten a comprehensive list of side effects... Ref: https://stackoverflow.com/questions/40244413/python-static-class-attribute-of-the-class-itself Rel: pytorch#87191 cc @kwen2501 Pull Request resolved: pytorch#87303 Approved by: https://github.com/wanchaol
atalman
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501 and
mingzhe09088
as code owners
pytorch-bot
bot
added
the
release notes: distributed (c10d)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87463
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 61b5ed6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seemethere
approved these changes
Oct 21, 2022
malfet
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tentatively marking as draft as I haven't gotten a comprehensive list of side effects...
Ref: https://stackoverflow.com/questions/40244413/python-static-class-attribute-of-the-class-itself Rel: #87191
cc @kwen2501
Pull Request resolved: #87303
Approved by: https://github.com/wanchaol