General in-place binary op support in dynamo #94203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94203
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 68d3336: BROKEN TRUNK - The following jobs failed but were present on the merge base 16387be:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jbschlosser
added a commit
that referenced
this pull request
Feb 6, 2023
ghstack-source-id: c39b81dba828f18b9a4522729297bd1f7dce3642 Pull Request resolved: #94203
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
Chillee,
ezyang,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
reviewed
Feb 6, 2023
ezyang
approved these changes
Feb 6, 2023
Continues the approach taken in #93271, expanding support to in-place binary ops (e.g. `__iadd__`). cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
jbschlosser
added a commit
that referenced
this pull request
Feb 6, 2023
ghstack-source-id: 1742cdc36d3c250a23c4033f288e4c597f51cc87 Pull Request resolved: #94203
|
@pytorchbot merge -f "Unrelated timeout" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Continues the approach taken in #93271, expanding support to in-place binary ops (e.g.
__iadd__).cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire