[MPS] Fix in-place add and sub with alpha == 0.0 #96184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96184
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ca5c1b4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
|
@pytorchbot merge -f "All tests are green." |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Apart from fixing the below issue, this PR integrates the test for `sub` into the test for `add` as they are implemented using the same template. Fixes #96065 Pull Request resolved: pytorch/pytorch#96184 Approved by: https://github.com/kulinseth
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Apart from fixing the below issue, this PR integrates the test for `sub` into the test for `add` as they are implemented using the same template. Fixes #96065 Pull Request resolved: pytorch/pytorch#96184 Approved by: https://github.com/kulinseth
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
Apart from fixing the below issue, this PR integrates the test for `sub` into the test for `add` as they are implemented using the same template. Fixes pytorch#96065 Pull Request resolved: pytorch#96184 Approved by: https://github.com/kulinseth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from fixing the below issue, this PR integrates the test for
subinto the test foraddas they are implemented using the same template.Fixes #96065