Skip to content

[BugFix] Fix wrong assertion about collector and buffer #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[BugFix] Fix wrong assertion about collector and buffer #3176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions torchrl/trainers/algorithms/configs/trainers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ def _make_sac_trainer(*args, **kwargs) -> SACTrainer:
elif replay_buffer is not None:
collector = collector(replay_buffer=replay_buffer)
elif getattr(collector, "replay_buffer", None) is None:
if collector.replay_buffer is None or replay_buffer is None:
if async_collection and (
collector.replay_buffer is None or replay_buffer is None
):
raise ValueError(
"replay_buffer must be provided when async_collection is True"
)
Expand Down Expand Up @@ -230,7 +232,7 @@ def _make_ppo_trainer(*args, **kwargs) -> PPOTrainer:
collector = collector()
else:
collector = collector(replay_buffer=replay_buffer)
elif getattr(collector, "replay_buffer", None) is None:
elif async_collection and getattr(collector, "replay_buffer", None) is None:
raise RuntimeError(
"replay_buffer must be provided when async_collection is True"
)
Expand Down
Loading