From 489c2f7dbb6b6811761845b811126ffebe514921 Mon Sep 17 00:00:00 2001 From: vmoens Date: Tue, 20 Dec 2022 14:09:10 +0000 Subject: [PATCH 1/6] init --- .circleci/unittest/linux/scripts/install.sh | 2 +- .circleci/unittest/linux_examples/scripts/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_brax/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_gym/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_habitat/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_jumanji/install.sh | 2 +- .circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh | 2 +- .circleci/unittest/linux_optdeps/scripts/install.sh | 2 +- .circleci/unittest/linux_stable/scripts/install.sh | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.circleci/unittest/linux/scripts/install.sh b/.circleci/unittest/linux/scripts/install.sh index ad126f23b0a..96c2d783d8f 100755 --- a/.circleci/unittest/linux/scripts/install.sh +++ b/.circleci/unittest/linux/scripts/install.sh @@ -40,7 +40,7 @@ python -c "import functorch" pip install git+https://github.com/pytorch/torchsnapshot # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed printf "* Installing torchrl\n" python setup.py develop diff --git a/.circleci/unittest/linux_examples/scripts/install.sh b/.circleci/unittest/linux_examples/scripts/install.sh index ad126f23b0a..96c2d783d8f 100755 --- a/.circleci/unittest/linux_examples/scripts/install.sh +++ b/.circleci/unittest/linux_examples/scripts/install.sh @@ -40,7 +40,7 @@ python -c "import functorch" pip install git+https://github.com/pytorch/torchsnapshot # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed printf "* Installing torchrl\n" python setup.py develop diff --git a/.circleci/unittest/linux_libs/scripts_brax/install.sh b/.circleci/unittest/linux_libs/scripts_brax/install.sh index 767070f2b25..ce393c22e8a 100755 --- a/.circleci/unittest/linux_libs/scripts_brax/install.sh +++ b/.circleci/unittest/linux_libs/scripts_brax/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_gym/install.sh b/.circleci/unittest/linux_libs/scripts_gym/install.sh index 0cdee0320c1..e1d9bc27153 100755 --- a/.circleci/unittest/linux_libs/scripts_gym/install.sh +++ b/.circleci/unittest/linux_libs/scripts_gym/install.sh @@ -42,7 +42,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_habitat/install.sh b/.circleci/unittest/linux_libs/scripts_habitat/install.sh index e5833cd1356..169eb404569 100755 --- a/.circleci/unittest/linux_libs/scripts_habitat/install.sh +++ b/.circleci/unittest/linux_libs/scripts_habitat/install.sh @@ -38,7 +38,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_jumanji/install.sh b/.circleci/unittest/linux_libs/scripts_jumanji/install.sh index 767070f2b25..ce393c22e8a 100755 --- a/.circleci/unittest/linux_libs/scripts_jumanji/install.sh +++ b/.circleci/unittest/linux_libs/scripts_jumanji/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh b/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh index 0cdee0320c1..e1d9bc27153 100755 --- a/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh +++ b/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh @@ -42,7 +42,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import tensordict" diff --git a/.circleci/unittest/linux_optdeps/scripts/install.sh b/.circleci/unittest/linux_optdeps/scripts/install.sh index 84951e95f24..cf264adc67b 100755 --- a/.circleci/unittest/linux_optdeps/scripts/install.sh +++ b/.circleci/unittest/linux_optdeps/scripts/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import functorch" diff --git a/.circleci/unittest/linux_stable/scripts/install.sh b/.circleci/unittest/linux_stable/scripts/install.sh index e8688cc825d..583b9e67a51 100755 --- a/.circleci/unittest/linux_stable/scripts/install.sh +++ b/.circleci/unittest/linux_stable/scripts/install.sh @@ -34,7 +34,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict +pip install git+https://github.com/pytorch-labs/tensordict@speed # smoke test python -c "import torch;import functorch" From 47fec5481a839a910f57295cbb08272e4349d505 Mon Sep 17 00:00:00 2001 From: vmoens Date: Thu, 22 Dec 2022 09:02:06 +0100 Subject: [PATCH 2/6] empty From a02c101950cdcfa00b7c8b4eee5a36d5eb9a4dc4 Mon Sep 17 00:00:00 2001 From: vmoens Date: Thu, 22 Dec 2022 09:06:20 +0100 Subject: [PATCH 3/6] empty From 93c03db13b23d238f90dc7b384d584f79dc5ba01 Mon Sep 17 00:00:00 2001 From: vmoens Date: Thu, 22 Dec 2022 10:16:31 +0100 Subject: [PATCH 4/6] amend --- test/test_shared.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/test_shared.py b/test/test_shared.py index f93adcaa90b..f28c4d81d4a 100644 --- a/test/test_shared.py +++ b/test/test_shared.py @@ -59,7 +59,9 @@ def test_shared(self, indexing_method): td = tensordict.clone().share_memory_() if indexing_method == 0: subtd = TensorDict( - source={key: item[0] for key, item in td.items()}, batch_size=[] + source={key: item[0] for key, item in td.items()}, + batch_size=[], + _is_shared=True, ) elif indexing_method == 1: subtd = td.get_sub_tensordict(0) From 143bd96c6bb1cadb7ea66a19793ae803ebfa5dfa Mon Sep 17 00:00:00 2001 From: vmoens Date: Thu, 22 Dec 2022 11:24:28 +0100 Subject: [PATCH 5/6] empty From dd9868d02ff57dc094ba1c1fee6d176d8b449417 Mon Sep 17 00:00:00 2001 From: vmoens Date: Thu, 22 Dec 2022 12:23:50 +0100 Subject: [PATCH 6/6] run legit tests --- .circleci/unittest/linux/scripts/install.sh | 2 +- .circleci/unittest/linux_examples/scripts/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_brax/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_gym/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_habitat/install.sh | 2 +- .circleci/unittest/linux_libs/scripts_jumanji/install.sh | 2 +- .circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh | 2 +- .circleci/unittest/linux_optdeps/scripts/install.sh | 2 +- .circleci/unittest/linux_stable/scripts/install.sh | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.circleci/unittest/linux/scripts/install.sh b/.circleci/unittest/linux/scripts/install.sh index 96c2d783d8f..ad126f23b0a 100755 --- a/.circleci/unittest/linux/scripts/install.sh +++ b/.circleci/unittest/linux/scripts/install.sh @@ -40,7 +40,7 @@ python -c "import functorch" pip install git+https://github.com/pytorch/torchsnapshot # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict printf "* Installing torchrl\n" python setup.py develop diff --git a/.circleci/unittest/linux_examples/scripts/install.sh b/.circleci/unittest/linux_examples/scripts/install.sh index 96c2d783d8f..ad126f23b0a 100755 --- a/.circleci/unittest/linux_examples/scripts/install.sh +++ b/.circleci/unittest/linux_examples/scripts/install.sh @@ -40,7 +40,7 @@ python -c "import functorch" pip install git+https://github.com/pytorch/torchsnapshot # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict printf "* Installing torchrl\n" python setup.py develop diff --git a/.circleci/unittest/linux_libs/scripts_brax/install.sh b/.circleci/unittest/linux_libs/scripts_brax/install.sh index ce393c22e8a..767070f2b25 100755 --- a/.circleci/unittest/linux_libs/scripts_brax/install.sh +++ b/.circleci/unittest/linux_libs/scripts_brax/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_gym/install.sh b/.circleci/unittest/linux_libs/scripts_gym/install.sh index e1d9bc27153..0cdee0320c1 100755 --- a/.circleci/unittest/linux_libs/scripts_gym/install.sh +++ b/.circleci/unittest/linux_libs/scripts_gym/install.sh @@ -42,7 +42,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_habitat/install.sh b/.circleci/unittest/linux_libs/scripts_habitat/install.sh index 169eb404569..e5833cd1356 100755 --- a/.circleci/unittest/linux_libs/scripts_habitat/install.sh +++ b/.circleci/unittest/linux_libs/scripts_habitat/install.sh @@ -38,7 +38,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_libs/scripts_jumanji/install.sh b/.circleci/unittest/linux_libs/scripts_jumanji/install.sh index ce393c22e8a..767070f2b25 100755 --- a/.circleci/unittest/linux_libs/scripts_jumanji/install.sh +++ b/.circleci/unittest/linux_libs/scripts_jumanji/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import functorch;import tensordict" diff --git a/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh b/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh index e1d9bc27153..0cdee0320c1 100755 --- a/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh +++ b/.circleci/unittest/linux_olddeps/scripts_gym_0_13/install.sh @@ -42,7 +42,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import tensordict" diff --git a/.circleci/unittest/linux_optdeps/scripts/install.sh b/.circleci/unittest/linux_optdeps/scripts/install.sh index cf264adc67b..84951e95f24 100755 --- a/.circleci/unittest/linux_optdeps/scripts/install.sh +++ b/.circleci/unittest/linux_optdeps/scripts/install.sh @@ -36,7 +36,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import functorch" diff --git a/.circleci/unittest/linux_stable/scripts/install.sh b/.circleci/unittest/linux_stable/scripts/install.sh index 583b9e67a51..e8688cc825d 100755 --- a/.circleci/unittest/linux_stable/scripts/install.sh +++ b/.circleci/unittest/linux_stable/scripts/install.sh @@ -34,7 +34,7 @@ else fi # install tensordict -pip install git+https://github.com/pytorch-labs/tensordict@speed +pip install git+https://github.com/pytorch-labs/tensordict # smoke test python -c "import torch;import functorch"