Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tensordict/_td.py
Original file line number Diff line number Diff line change
Expand Up @@ -2330,8 +2330,6 @@ def rename_key_(
# these checks are not perfect, tuples that are not tuples of strings or empty
# tuples could go through but (1) it will raise an error anyway and (2)
# those checks are expensive when repeated often.
if old_key == new_key:
return self
if not isinstance(old_key, (str, tuple)):
raise TypeError(
f"Expected old_name to be a string or a tuple of strings but found {type(old_key)}"
Expand All @@ -2340,21 +2338,25 @@ def rename_key_(
raise TypeError(
f"Expected new_name to be a string or a tuple of strings but found {type(new_key)}"
)
old_key = unravel_key(old_key)
new_key = unravel_key(new_key)
if old_key == new_key:
return self
if safe and (new_key in self.keys(include_nested=True)):
raise KeyError(f"key {new_key} already present in TensorDict.")

if isinstance(new_key, str):
self._set_str(
new_key,
self.get(old_key),
self.get(old_key, default=NO_DEFAULT),
inplace=False,
validated=True,
non_blocking=False,
)
else:
self._set_tuple(
new_key,
self.get(old_key),
self.get(old_key, default=NO_DEFAULT),
inplace=False,
validated=True,
non_blocking=False,
Expand Down Expand Up @@ -4195,7 +4197,7 @@ def __contains__(self, key: NestedKey) -> bool:
if self.leaves_only:
# TODO: make this faster for LazyStacked without compromising regular
return not _is_tensor_collection(
type(self.tensordict._get_str(key))
type(self.tensordict._get_str(key, NO_DEFAULT))
)
return True
return False
Expand Down
2 changes: 2 additions & 0 deletions tensordict/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1500,6 +1500,8 @@ def _get_leaf_tensordict(
tensordict = hook(tensordict, key)
else:
tensordict = tensordict.get(key[0])
if tensordict is None:
raise KeyError
key = key[1:]
return tensordict, key[0]

Expand Down