adds new LaunchTemplate for linux instances with Nvidia GPUs enabling its monitoring #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
jeanschmidt
changed the title
jeanschmidt
changed the title
seemethere
approved these changes
Oct 17, 2022
izaitsevfb
reviewed
Oct 18, 2022
| console.debug(`Created SSM Parameters(s): ${createdSSMParams.join(',')}`); | ||
| } | ||
|
|
||
| function getLaunchTemplateName(runnerParameters: RunnerInputParameters): Array<string | undefined> { |
Contributor
There was a problem hiding this comment.
nit: returning an object with two named fields, or a tuple type [string | undefined, string | undefined] is more suited here.
izaitsevfb
approved these changes
Oct 18, 2022
Contributor
izaitsevfb
left a comment
izaitsevfb
left a comment
There was a problem hiding this comment.
LGTM
I wonder, could there be an easier way to do optional measurements? Or do we want to track the metrics from nvidia runners separately?
kit1980
pushed a commit
that referenced
this pull request
Nov 23, 2022
… its monitoring (#890) Adds LaunchTemplate `${var.environment}-action-linux-runner-nvidia` where main startup script points to the SSM where cloudWatch agent config is set on SSM `aws_ssm_parameter.cloudwatch_agent_config_runner_linux_nvidia[0].name`. This template is then chose when the runner names ends contains `.nvidia.gpu` on its name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds LaunchTemplate
${var.environment}-action-linux-runner-nvidiawhere main startup script points to the SSM where cloudWatch agent config is set on SSMaws_ssm_parameter.cloudwatch_agent_config_runner_linux_nvidia[0].name. This template is then chose when the runner names ends contains.nvidia.gpuon its name.