Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README file for 0.9.0 release #1198

Merged
merged 17 commits into from Feb 26, 2021

Conversation

zhangguanheng66
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #1198 (724d56c) into master (f0df69f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1198   +/-   ##
=======================================
  Coverage   73.23%   73.23%           
=======================================
  Files          67       67           
  Lines        3718     3718           
=======================================
  Hits         2723     2723           
  Misses        995      995           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0df69f...4beb807. Read the comment docs.

* ``torchtext.legacy.data.pipeline``
* ``torchtext.legacy.datasets``

We have a `migration tutorial <https://fburl.com/9hbq843y>`_ to help users switch to the torchtext datasets in ``v0.9.0`` release. For the users who still want the legacy components, they can add ``legacy`` to the import path.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fburls are not public

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can export a colab notebook as an ipython notebook and upload the ipython notebook here.

Then you can create a colab link that uses the ipython on github like so:

https://colab.research.google.com/github/pytorch/nestedtensor/blob/master/tutorials/notebooks/basic.ipynb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
pip install --pre torch torchtext -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html

For more detailed instructions, please refer to `Install PyTorch <https://pytorch.org/get-started/locally/>`_. It should be noted that the new building blocks are still under development, and the APIs have not been solidified.
Note: the legacy code discussed in `torchtext v0.7.0 release note <https://github.com/pytorch/text/releases/tag/v0.7.0-rc3>`_ has been retired to `torchtext.legacy <#legacy>`_ folder. Those legacy code will not be maintained by the development team, and we plan to fully remove them in the future release. See the Legacy session for more details.

Installation
Copy link
Contributor

@parmeet parmeet Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line below, I think Anaconda is not the package manager but is more like a distribution whereas conda is the underlying package manager. Should we rephrase it to something like: "We recommend conda as package manager that comes with Anaconda or miniconda"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we are using the consistent statement on PyTorch website: "Anaconda is our recommended package manager..." - link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can probably leave it as such then to keep the consistency with PyTorch as this is a minor technical detail that users won't mind :)

@cpuhrsch Just FYI

Others are planned or a work in progress:
* Transforms
* Vocabulary
* Vectors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide short note or one liner description of each of "Transforms", "Vocabulary" and "Vectors". Or at-least a link where users can learn more about it? Since these are prototype features where we probably want some feedback, users might want to learn about them quickly through somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Let me add those links and some descriptions.

@zhangguanheng66 zhangguanheng66 merged commit 16774db into pytorch:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants