This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Improve icolumn.py cc 4/4 test_string_column (#410) #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37289878 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37289878 |
andrewaikens87
added a commit
to andrewaikens87/torcharrow
that referenced
this pull request
Jun 29, 2022
Summary: Pull Request resolved: pytorch#414 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Differential Revision: D37289878 fbshipit-source-id: 9631ed612fbb10bc5bcd887e01388ebb6bbac7d4
andrewaikens87
force-pushed
the
export-D37289878-to-fbsync
branch
from
6a07381 to
bf94715
Compare
andrewaikens87
added a commit
to andrewaikens87/torcharrow
that referenced
this pull request
Jul 8, 2022
Summary: Pull Request resolved: pytorch#414 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Differential Revision: D37289878 fbshipit-source-id: 97013a58febaae3f8da1721d754fc10bd6b57ebf
andrewaikens87
force-pushed
the
export-D37289878-to-fbsync
branch
from
bf94715 to
6069097
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37289878 |
Summary: Pull Request resolved: pytorch#414 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Reviewed By: wenleix Differential Revision: D37289878 fbshipit-source-id: de03567d6beaf67267c78f6b2427bdcd018a9a90
andrewaikens87
force-pushed
the
export-D37289878-to-fbsync
branch
from
6069097 to
86adb8c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37289878 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
Summary: Pull Request resolved: #414 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Reviewed By: wenleix Differential Revision: D37289878 fbshipit-source-id: d7de16030ec77cdd39c06976305a9162be375b86
wenleix
pushed a commit
that referenced
this pull request
Jul 16, 2022
Summary: Pull Request resolved: #414 Improves test coverage for icolumn.py through test_string_column. icolumn.py has ~55% code coverage currently and this diff brings it to 78.3. Reviewed By: wenleix Differential Revision: D37289878 fbshipit-source-id: d7de16030ec77cdd39c06976305a9162be375b86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: #410
Improves test coverage for icolumn.py through test_string_column.
icolumn.py has ~55% code coverage currently and this diff brings it to 78.3.
Differential Revision: D37289878