Skip to content
This repository was archived by the owner on Nov 1, 2024. It is now read-only.

Update compatibility matrix in README #440

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Update compatibility matrix in README #440

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0b54a
Update compatibility matrix in README
bearzx Jul 13, 2022
fc9ed83
Update README.md
bearzx Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ conda create --name torcharrow python=3.7
conda activate torcharrow
```

### Version Compatibility

The following is the corresponding `torcharrow` versions and supported Python versions.

| `torch` | `torcharrow` | `python` |
| ------------------ | ------------------ | ----------------- |
| `main` / `nightly` | `main` / `nightly` | `>=3.7`, `<=3.10` |
| `1.12.0` / `1.13.0`| `0.1.0` / `0.2.0` | `>=3.7`, `<=3.10` |
Copy link
Contributor

@ejguan ejguan Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the version after / refer to nightly?
If it refers to two different official releases, you should split it into two rows.

Copy link
Contributor Author

@bearzx bearzx Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that's how I understood it. 0.1.0 is the official release, and 0.2.0 is the next version (nightly, not official yet).

Copy link
Contributor

@ejguan ejguan Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, the line 33 refers to nightly release.

Copy link
Contributor Author

@bearzx bearzx Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see ... then do you need to have the matrix for official release at all? Or just the main / nightly?



### Colab

Follow the instructions [in this Colab notebook](https://colab.research.google.com/drive/1S0ldwN7qNM37E4WZnnAEnzn1DWnAQ6Vt)
Expand Down