This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Remove fields from DType #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It's only avaiable for Struct type. Original motivation is to avoid some pyre warning, we can add explicit `cast` or more accurate type annotation for that. Differential Revision: D38266758 fbshipit-source-id: 93241a53c37d4e80c711543e33e59dfb38dd5555
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38266758 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 29, 2022
Summary: Pull Request resolved: #462 It's only available for Struct type. Original motivation is to avoid some pyre warning, looks like we can get the same outcome by adding explicit `cast` or more accurate type annotation. Reviewed By: dracifer Differential Revision: D38266758 fbshipit-source-id: db1587d69921746d8a32fda9bd98f639bc257e2f
wenleix
added a commit
that referenced
this pull request
Jul 30, 2022
Summary: Pull Request resolved: #462 It's only available for Struct type. Original motivation is to avoid some pyre warning, looks like we can get the same outcome by adding explicit `cast` or more accurate type annotation. Reviewed By: dracifer Differential Revision: D38266758 fbshipit-source-id: db1587d69921746d8a32fda9bd98f639bc257e2f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
It's only avaiable for Struct type.
Original motivation is to avoid some pyre warning, we can add explicit
castor more accurate type annotation for that.Differential Revision: D38266758