From c0cdc3b1dab889e9de136f06b73d0faeeffdc989 Mon Sep 17 00:00:00 2001 From: Laith Sakka Date: Fri, 26 Aug 2022 07:44:23 -0700 Subject: [PATCH] Pass not nullable context and results by reference (#479) Summary: Pull Request resolved: https://github.com/pytorch/torcharrow/pull/479 X-link: https://github.com/facebookincubator/velox/pull/2367 Those are always assumed not null and de-referenced with out checking, hence passing them by reference is more suitable. Reviewed By: kagamiori Differential Revision: D38946493 fbshipit-source-id: 0f5b0b3b926d5f12a56d35a57a9549dd3393a526 --- csrc/velox/column.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/csrc/velox/column.cpp b/csrc/velox/column.cpp index c7a4ce312..2ad88f7a8 100644 --- a/csrc/velox/column.cpp +++ b/csrc/velox/column.cpp @@ -452,7 +452,7 @@ std::unique_ptr OperatorHandle::call( &TorchArrowGlobalStatic::execContext(), exprSet_.get(), inputRows.get()); velox::SelectivityVector select(size); std::vector outputRows(1); - exprSet_->eval(0, 1, true, select, &evalCtx, &outputRows); + exprSet_->eval(0, 1, true, select, evalCtx, outputRows); // TODO: This causes an extra type-based dispatch. // We can optimize it by template OperatorHandle by return type