[Full DTensor][Reland] Add full_dtensor flag #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Nov 11, 2025
When full_dtensor is True, the compute_placement will be preserved. This means that `to_local()` won't be called for fsdp only case. nD parallelism case (fsdp + tp) will error out as we have not implemented this case. This argument doesn't affect the current simple_fsdp. We have verified `full_dtensor=True` case with the full dtensor skleton PR, which will be published once it is ready. ghstack-source-id: ac4d1bf Pull-Request: #2013
meta-cla
bot
added
the
CLA Signed
fegin
changed the title
tianyu-l
approved these changes
Nov 11, 2025
ahoffman-aws
pushed a commit
to drcanchi-aws/torchtitan
that referenced
this pull request
Nov 11, 2025
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0) (oldest at bottom): * __->__ pytorch#2013 When full_dtensor is True, the compute_placement will be preserved. This means that `to_local()` won't be called for fsdp only case. nD parallelism case (fsdp + tp) will error out as we have not implemented this case. This argument doesn't affect the current simple_fsdp. We have verified `full_dtensor=True` case with the full dtensor skleton PR, which will be published once it is ready. **This is a reland PR of pytorch#2002. The previous one was broken during rebase.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When full_dtensor is True, the compute_placement will be preserved. This means that
to_local()won't be called for fsdp only case. nD parallelism case (fsdp + tp) will error out as we have not implemented this case.This argument doesn't affect the current simple_fsdp. We have verified
full_dtensor=Truecase with the full dtensor skleton PR, which will be published once it is ready.This is a reland PR of #2002. The previous one was broken during rebase.