Skip to content

Run Torchtitan ROCm workflow on cron schedule & push to Main branch only #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
+12 −6
Merged

Run Torchtitan ROCm workflow on cron schedule & push to Main branch only #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f5b1e1
Replaced TEST_WITH_ROCM environment variable with gpu_arch_type argum…
akashveramd Nov 8, 2025
827a6a6
Running Torchtitan ROCm workflow on cron schedule & only when push to…
akashveramd Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/integration_test_8gpu_features.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ permissions:

jobs:
build-test:
if: |
matrix.gpu-arch-type == 'cuda' ||
(matrix.gpu-arch-type == 'rocm' &&
(github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'schedule'))
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
strategy:
fail-fast: false
Expand Down Expand Up @@ -73,8 +77,7 @@ jobs:
sudo mkdir -p "$RUNNER_TEMP/artifacts-to-be-uploaded"
sudo chown -R $(id -u):$(id -g) "$RUNNER_TEMP/artifacts-to-be-uploaded"

export TEST_WITH_ROCM=$([[ "${{ matrix.gpu-arch-type }}" == "rocm" ]] && echo 1 || echo 0)
python -m tests.integration_tests.run_tests --test_suite features $RUNNER_TEMP/artifacts-to-be-uploaded --ngpu 8
python -m tests.integration_tests.run_tests --gpu_arch_type ${{ matrix.gpu-arch-type }} --test_suite features $RUNNER_TEMP/artifacts-to-be-uploaded --ngpu 8

rm -rf $RUNNER_TEMP/artifacts-to-be-uploaded/*/checkpoint
rm -rf artifacts-to-be-uploaded/*/checkpoint
11 changes: 7 additions & 4 deletions tests/integration_tests/run_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
}


TEST_WITH_ROCM = os.getenv("TEST_WITH_ROCM", "0") == "1"


def _run_cmd(cmd):
return subprocess.run([cmd], text=True, shell=True)

Expand Down Expand Up @@ -92,7 +89,7 @@ def run_tests(args, test_list: list[OverrideDefinitions]):
continue

# Skip the test for ROCm
if TEST_WITH_ROCM and test_flavor.skip_rocm_test:
if args.gpu_arch_type == "rocm" and test_flavor.skip_rocm_test:
continue

# Check if we have enough GPUs
Expand All @@ -110,6 +107,12 @@ def main():
parser.add_argument(
"output_dir", help="Directory to dump results generated by tests"
)
parser.add_argument(
"--gpu_arch_type",
default="cuda",
choices=["cuda", "rocm"],
help="GPU architecture type. Must be specified as either 'cuda' or 'rocm'.",
)
parser.add_argument(
"--test_suite",
default="features",
Expand Down
Loading