From 71ca4517daa4c3639f366a0c01e30b4c2353347a Mon Sep 17 00:00:00 2001 From: tianyu-l <150487191+tianyu-l@users.noreply.github.com> Date: Tue, 11 Nov 2025 17:18:00 -0800 Subject: [PATCH] =?UTF-8?q?Revert=20"Run=20Torchtitan=20ROCm=20workflow=20?= =?UTF-8?q?on=20cron=20schedule=20&=20push=20to=20Main=20branch=20o?= =?UTF-8?q?=E2=80=A6"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 2f9b44da8eea448d7194eb180331c0734133961b. --- .github/workflows/integration_test_8gpu_features.yaml | 7 ++----- tests/integration_tests/run_tests.py | 11 ++++------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/integration_test_8gpu_features.yaml b/.github/workflows/integration_test_8gpu_features.yaml index e97d22c3b7..c6e8ed30d5 100644 --- a/.github/workflows/integration_test_8gpu_features.yaml +++ b/.github/workflows/integration_test_8gpu_features.yaml @@ -26,10 +26,6 @@ permissions: jobs: build-test: - if: | - matrix.gpu-arch-type == 'cuda' || - (matrix.gpu-arch-type == 'rocm' && - (github.event_name == 'push' && github.ref == 'refs/heads/main' || github.event_name == 'schedule')) uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main strategy: fail-fast: false @@ -77,7 +73,8 @@ jobs: sudo mkdir -p "$RUNNER_TEMP/artifacts-to-be-uploaded" sudo chown -R $(id -u):$(id -g) "$RUNNER_TEMP/artifacts-to-be-uploaded" - python -m tests.integration_tests.run_tests --gpu_arch_type ${{ matrix.gpu-arch-type }} --test_suite features $RUNNER_TEMP/artifacts-to-be-uploaded --ngpu 8 + export TEST_WITH_ROCM=$([[ "${{ matrix.gpu-arch-type }}" == "rocm" ]] && echo 1 || echo 0) + python -m tests.integration_tests.run_tests --test_suite features $RUNNER_TEMP/artifacts-to-be-uploaded --ngpu 8 rm -rf $RUNNER_TEMP/artifacts-to-be-uploaded/*/checkpoint rm -rf artifacts-to-be-uploaded/*/checkpoint diff --git a/tests/integration_tests/run_tests.py b/tests/integration_tests/run_tests.py index b2cb8ea503..011fa25554 100644 --- a/tests/integration_tests/run_tests.py +++ b/tests/integration_tests/run_tests.py @@ -25,6 +25,9 @@ } +TEST_WITH_ROCM = os.getenv("TEST_WITH_ROCM", "0") == "1" + + def _run_cmd(cmd): return subprocess.run([cmd], text=True, shell=True) @@ -89,7 +92,7 @@ def run_tests(args, test_list: list[OverrideDefinitions]): continue # Skip the test for ROCm - if args.gpu_arch_type == "rocm" and test_flavor.skip_rocm_test: + if TEST_WITH_ROCM and test_flavor.skip_rocm_test: continue # Check if we have enough GPUs @@ -107,12 +110,6 @@ def main(): parser.add_argument( "output_dir", help="Directory to dump results generated by tests" ) - parser.add_argument( - "--gpu_arch_type", - default="cuda", - choices=["cuda", "rocm"], - help="GPU architecture type. Must be specified as either 'cuda' or 'rocm'.", - ) parser.add_argument( "--test_suite", default="features",